-
Notifications
You must be signed in to change notification settings - Fork 4
fix: Harmonize font-family across all components[420] #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
b37d083
to
4050956
Compare
eb6461b
to
5dbfbd7
Compare
shebz2023
approved these changes
Aug 30, 2024
5a35da6
to
8b70991
Compare
8b70991
to
d2db1c7
Compare
JacquelineTuyisenge
approved these changes
Aug 30, 2024
d2db1c7
to
da8f2b1
Compare
da8f2b1
to
382bb45
Compare
382bb45
to
d103d97
Compare
d103d97
to
feadebc
Compare
feadebc
to
b8416cc
Compare
b8416cc
to
2c8c40a
Compare
2c8c40a
to
9944790
Compare
Updated the global styles to apply the 'PT Serif' font-family across all components. Ensured that there are no component-specific overrides that conflict with the global font style. Closes #420
9944790
to
a5dc745
Compare
Salim-54
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the global styles to apply the 'PT Serif' font-family across all components. Ensured that there are no component-specific overrides that conflict with the global font style.
Closes #420
PR Description
This pull request updates the global styles to ensure all components use the "PT Serif" font-family. The change was applied globally to the body element, and all components were verified to adhere to the new font style. Additionally, checks were made to prevent any component-specific overrides from conflicting with the global style.
Description of tasks that were expected to be completed
Changes Included:
Import "PT Serif" from Google Fonts.
Updated global CSS to apply the "PT Serif" font-family across all components.
Removed any conflicting font-family styles from individual components.
How has this been tested?
Manual testing was performed to ensure the font was correctly applied across all components.
Number of Commits
The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.
Screenshots (If appropriate)
Please check this Checklist before you submit your PR: