Skip to content

fix: Harmonize font-family across all components[420] #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

andremugabo
Copy link
Contributor

@andremugabo andremugabo commented Aug 30, 2024

Updated the global styles to apply the 'PT Serif' font-family across all components. Ensured that there are no component-specific overrides that conflict with the global font style.

Closes #420

PR Description

This pull request updates the global styles to ensure all components use the "PT Serif" font-family. The change was applied globally to the body element, and all components were verified to adhere to the new font style. Additionally, checks were made to prevent any component-specific overrides from conflicting with the global style.

Description of tasks that were expected to be completed

Changes Included:
Import "PT Serif" from Google Fonts.
Updated global CSS to apply the "PT Serif" font-family across all components.
Removed any conflicting font-family styles from individual components.

How has this been tested?

Manual testing was performed to ensure the font was correctly applied across all components.

Number of Commits

The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.

Screenshots (If appropriate)

Screenshot 2024-08-30 120545

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 10:06pm

@andremugabo andremugabo changed the title fix: Harmonize font-family across all components fix: Harmonize font-family across all components[#420] Aug 30, 2024
@andremugabo andremugabo requested review from shebz2023, JacquelineTuyisenge, 13XAVI, ncutixavier and ceelogre and removed request for 13XAVI August 30, 2024 10:13
@andremugabo andremugabo changed the title fix: Harmonize font-family across all components[#420] fix: Harmonize font-family across all components[420] Aug 30, 2024
@andremugabo andremugabo force-pushed the ft-font-harmonization branch from b37d083 to 4050956 Compare August 30, 2024 10:21
@andremugabo andremugabo force-pushed the ft-font-harmonization branch from eb6461b to 5dbfbd7 Compare August 30, 2024 10:59
Updated the global styles to apply the 'PT Serif' font-family across all components. Ensured that there are no component-specific overrides that conflict with the global font style.

Closes #420
@Salim-54 Salim-54 merged commit 0d8badc into develop Sep 5, 2024
6 checks passed
@ceelogre ceelogre deleted the ft-font-harmonization branch September 30, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font harmonization
4 participants