Skip to content

#426 refactors and fixes user notifications feature #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

aimedivin
Copy link
Member

@aimedivin aimedivin commented Aug 31, 2024

PR Description

This PR refactors the notification modal to work with current API, it also Implements and improves UI.

Description of tasks that were expected to be completed

  • Refactor Notification Modal code to be compatible with the current API
  • Updated the design to follow the latest UI designs.
  • Ensure its responsiveness on all possible screens.
  • Tests were added to ensure that everything works correctly.

How has this been tested?

  • Clone this repository and navigate to the project directory
  • Ensure You have backend service running and set your .env file using .env.example.
  git clone https://github.com/atlp-rwanda/atlp-pulse-fn.git
  cd atlp-pulse-fn
  git checkout fix-notification
  npm i
  npm run test

Number of Commits

The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Screenshots (If appropriate)

BEFORE

image

AFTER

image

Copy link

vercel bot commented Aug 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 8:52am

@aimedivin aimedivin self-assigned this Sep 1, 2024
@aimedivin aimedivin linked an issue Sep 2, 2024 that may be closed by this pull request
@aimedivin aimedivin linked an issue Sep 2, 2024 that may be closed by this pull request
@aimedivin aimedivin removed a link to an issue Sep 2, 2024
This was linked to issues Sep 2, 2024
This was linked to issues Sep 2, 2024
@igorihimbazwe igorihimbazwe added the Steppers Team Steppers label Sep 2, 2024
@aimedivin aimedivin changed the title fix(notification): refactors and fixes user notifications feature #426 refactors and fixes user notifications feature Sep 5, 2024
Copy link
Contributor

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ke-bean

This comment was marked as duplicate.

Copy link
Contributor

@Ke-bean Ke-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Salim-54 Salim-54 merged commit 40ddd61 into develop Sep 5, 2024
6 checks passed
@ceelogre ceelogre deleted the fix-notification branch September 30, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet