Chore: add redirect handler #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fredshema
requested review from
Mbabazi12,
MugemaneBertin2001,
aimeudoxie,
munezeromicha,
ncutixavier and
pacifiquemboni
fredshema
force-pushed
the
ch-redirect-handler
branch
from
1f6b9e5 to
1031ec5
Compare
pacifiquemboni
approved these changes
Sep 25, 2024
fredshema
force-pushed
the
ch-redirect-handler
branch
from
1031ec5 to
b17aa6d
Compare
fix: linting errors fix: fallback handler
fredshema
force-pushed
the
ch-redirect-handler
branch
from
b17aa6d to
c13aa3d
Compare
MugemaneBertin2001
approved these changes
Sep 25, 2024
MugemaneBertin2001
requested changes
Sep 25, 2024
Contributor
MugemaneBertin2001
left a comment
MugemaneBertin2001
left a comment
There was a problem hiding this comment.
Check on this @fredshema
Contributor
Author
|
This happens when a user doesn't have the mobile app installed. It will redirect to a fallback url specified in the link or the homepage. Did it redirect for you? |
MugemaneBertin2001
approved these changes
Sep 26, 2024
ncutixavier
approved these changes
Sep 26, 2024
JacquelineTuyisenge
pushed a commit
that referenced
this pull request
Sep 26, 2024
fix: linting errors fix: fallback handler
JacquelineTuyisenge
pushed a commit
that referenced
this pull request
Sep 26, 2024
fix: linting errors fix: fallback handler
Merged
JacquelineTuyisenge
pushed a commit
that referenced
this pull request
Sep 30, 2024
fix: linting errors fix: fallback handler
JacquelineTuyisenge
pushed a commit
that referenced
this pull request
Oct 1, 2024
fix: linting errors fix: fallback handler
JacquelineTuyisenge
pushed a commit
that referenced
this pull request
Oct 1, 2024
fix: linting errors fix: fallback handler
JacquelineTuyisenge
pushed a commit
that referenced
this pull request
Oct 2, 2024
fix: linting errors fix: fallback handler
JacquelineTuyisenge
pushed a commit
that referenced
this pull request
Oct 2, 2024
fix: linting errors fix: fallback handler
JacquelineTuyisenge
pushed a commit
that referenced
this pull request
Oct 2, 2024
fix: linting errors fix: fallback handler
ceelogre
pushed a commit
that referenced
this pull request
Oct 2, 2024
fix: linting errors fix: fallback handler Co-authored-by: Fred Shema <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds a page that will handle redirections from external links to other resources of pulse like the mobile app.
Description of tasks that were expected to be completed
How has this been tested?
Run the app and try opening the app on this link: http://localhost:3001/redirect?path=/register/123. There should be a redirect to the specified path.
Screenshots (If appropriate)
N/A