Skip to content

Conversation

@JacquelineTuyisenge
Copy link
Contributor

@JacquelineTuyisenge JacquelineTuyisenge commented Sep 24, 2024

PR Description

This pull request focuses on improving the web performance of the beta pulse app

Description of tasks that were expected to be completed

  • Removed Webpack from the project due to its slower bundling performance compared to Vite.
  • Integrated Vite for faster development and build times.
  • Updated project configurations to support Vite as the new bundler.

How has this been tested?

I have tested the application by:

  1. Serving the application locally using npm run dev.
  2. Measuring the initial load time using performance monitoring tools (e.g., Chrome DevTools, stop watch).
  3. Verifying that the application functions correctly without any errors after the migration.

The initial load times have improved significantly due to Vite's optimized bundling process.
you can check the loading time using this preview link of my Pull request: https://metron-devpulse-git-fix-load-time-502-metron.vercel.app/

Number of Commits

1 commit.

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generates no warnings
  • My test coverage meets the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 3:47pm

@JacquelineTuyisenge JacquelineTuyisenge changed the title #502 web-perfomance load time #502 web-perfomance load time : Migration from CRA to Vite Sep 26, 2024
Copy link
Contributor

@ceelogre ceelogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file:
https://github.com/atlp-rwanda/atlp-pulse-fn/blob/fix-load-time-502/.github/workflows/do.yml

Change on push to on pull_request so we can test the performance on beta.

@ceelogre
Copy link
Contributor

ceelogre commented Oct 2, 2024

Revert the change (on pull_request) #511 (review) then we will merge.

fix: linting errors

fix: fallback handler
@ceelogre ceelogre merged commit 4c34ae8 into develop Oct 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants