Skip to content

#575 Move client-side attendance logic to server #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

#575 Move client-side attendance logic to server #596

merged 1 commit into from
Nov 5, 2024

Conversation

@aimedivin
Copy link
Member

@aimedivin aimedivin commented Oct 21, 2024 •
edited
Loading

PR Description

This PR moves the attendance tracking logic from the client-side to the server-side to improve performance, scalability, and data security.

Description of tasks that were expected to be completed

  • Migrated client-side attendance tracking logic to the server.
  • Created new API endpoints to handle attendance-related requests.
  • A TTL is now able to record an attendance
  • Updated front-end code to communicate with the new server endpoints.
  • Ensured that the changes do not negatively impact any other functionality.

How has this been tested?

  • Clone this repository and navigate to the project directory
  • Ensure You have backend service running and set your .env file using .env.example.
  git clone https://github.com/atlp-rwanda/atlp-pulse-fn.git
  cd atlp-pulse-fn
  git checkout fix-attendance-logic
  npm I
  npm run test
  or
  npm run dev
  • Login in with valid TTL or coordinator credentials
  • Navigate to attendance page

Number of Commits

  • 1 Commit

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 4:02pm

@aimedivin aimedivin added the Steppers Team Steppers label Oct 21, 2024
@aimedivin aimedivin self-assigned this Oct 21, 2024
@aimedivin aimedivin linked an issue Oct 21, 2024 that may be closed by this pull request
Attendance data should be calculated on the server not client #575
Closed
@aimedivin aimedivin changed the title move client-side attendance logic to server #575 Move client-side attendance logic to server Oct 21, 2024
@aimedivin aimedivin force-pushed the fix-attendance-logic branch from 012f024 to ac38ace Compare October 22, 2024 09:35
@aimedivin aimedivin force-pushed the fix-attendance-logic branch from ac38ace to ff92f63 Compare October 22, 2024 09:46
@aimedivin aimedivin force-pushed the fix-attendance-logic branch from ff92f63 to 4422a5e Compare October 23, 2024 19:59
@aimedivin aimedivin force-pushed the fix-attendance-logic branch from 4422a5e to aca7fc9 Compare October 24, 2024 07:23
@aimedivin aimedivin force-pushed the fix-attendance-logic branch from aca7fc9 to a52a504 Compare October 24, 2024 10:27
@aimedivin aimedivin force-pushed the fix-attendance-logic branch from a52a504 to ff93c46 Compare October 25, 2024 08:45
@aimedivin aimedivin force-pushed the fix-attendance-logic branch from ff93c46 to 62573fe Compare October 28, 2024 10:12
@Salim-54
Copy link

Salim-54 commented Nov 1, 2024

Please integrate the backend into your Preview.

@aimedivin aimedivin force-pushed the fix-attendance-logic branch from 62573fe to e626659 Compare November 1, 2024 11:41
@aimedivin aimedivin force-pushed the fix-attendance-logic branch from e626659 to 2396439 Compare November 1, 2024 12:33
@aimedivin aimedivin force-pushed the fix-attendance-logic branch from 792aa12 to 05f1e9f Compare November 2, 2024 15:28
@aimedivin aimedivin force-pushed the fix-attendance-logic branch from 05f1e9f to 32f0ad3 Compare November 2, 2024 16:01
@Salim-54 Salim-54 merged commit 58eb885 into develop Nov 5, 2024
6 checks passed
Bananayosostene pushed a commit that referenced this pull request Nov 21, 2024
@GSinseswa721 @Bananayosostene
sPPS C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop
5b2944b 
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
edit 7d95521 sort invitations by descending or ascending (#590)

s fix-docs (#587)
s b1a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)S C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
s 7d95521 sort invitations by descending or ascending (#590)
s 711747f fix-docs (#587)
s b2a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)ort invitations by descending or ascending (#590)

Co-authored-by: niyobertin <[email protected]>

fix-docs (#587)

fix Internanationalization testimonial section (#592)

changing undrop icon (#583)

fx<search> improving search invitation to listern to typing event (#591)

fix(#404):login activies display in a table (#576)

fix(#403):adding a not found page (#593)

fix(#599): Improve invitation table pagination (#553)

fix(#595):Improve the dark mode skeleton to match dark design (#598)

fix(#404): add skeleton loader on login activities table (#600)

Remove ratings legacy feature #225 (#594)

fix(#391):Enable Consistent Edit For All Cohorts (#607)

-As an admin, I have ability to edit all cohorts that I am permitted to manage

fix(#605):table responsiveness (#611)

Co-authored-by: niyobertin <[email protected]>

(#606) Harmonize action button theme across tables in TTL's portal (#613)

fix(#394): Resolve Trainee Detail View Errors (#614)

average ratings (#617)

TTL-Page improvement (#601)

* droping and undropping ttl

* ft-droping-and-undropping-ttl

* ft-droping-and-undropping-ttl

* ft-ttl-page-improvement

* fix: move client-side attendance logic to server

* feat(trainee-attendance): implements a trainee-side attendance

fix: move client-side attendance logic to server (#596)

Enable admin to view all programs with user breakdown per program-#422 (#618)

(fix): add coordinator dashboard page (#608)

main admin dashboard

new piechart and stats updated

new piechart and stats updated

ft-admin-dashboard-can-vieww-table-teams

new piechart and stats updated
Bananayosostene pushed a commit that referenced this pull request Nov 22, 2024
@GSinseswa721 @Bananayosostene
admin dashoard functinality
f3d9c53 
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
edit 7d95521 sort invitations by descending or ascending (#590)

s fix-docs (#587)
s b1a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)S C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
s 7d95521 sort invitations by descending or ascending (#590)
s 711747f fix-docs (#587)
s b2a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)ort invitations by descending or ascending (#590)

Co-authored-by: niyobertin <[email protected]>

fix-docs (#587)

fix Internanationalization testimonial section (#592)

changing undrop icon (#583)

fx<search> improving search invitation to listern to typing event (#591)

fix(#404):login activies display in a table (#576)

fix(#403):adding a not found page (#593)

fix(#599): Improve invitation table pagination (#553)

fix(#595):Improve the dark mode skeleton to match dark design (#598)

fix(#404): add skeleton loader on login activities table (#600)

Remove ratings legacy feature #225 (#594)

fix(#391):Enable Consistent Edit For All Cohorts (#607)

-As an admin, I have ability to edit all cohorts that I am permitted to manage

fix(#605):table responsiveness (#611)

Co-authored-by: niyobertin <[email protected]>

(#606) Harmonize action button theme across tables in TTL's portal (#613)

fix(#394): Resolve Trainee Detail View Errors (#614)

average ratings (#617)

TTL-Page improvement (#601)

* droping and undropping ttl

* ft-droping-and-undropping-ttl

* ft-droping-and-undropping-ttl

* ft-ttl-page-improvement

* fix: move client-side attendance logic to server

* feat(trainee-attendance): implements a trainee-side attendance

fix: move client-side attendance logic to server (#596)

Enable admin to view all programs with user breakdown per program-#422 (#618)

(fix): add coordinator dashboard page (#608)

main admin dashboard

new piechart and stats updated

new piechart and stats updated

ft-admin-dashboard-can-vieww-table-teams

new piechart and stats updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kanu-cast kanu-cast kanu-cast approved these changes

@elijahladdie elijahladdie elijahladdie approved these changes

@igorihimbazwe igorihimbazwe igorihimbazwe approved these changes

@Calebgisa72 Calebgisa72 Calebgisa72 approved these changes

@Salim-54 Salim-54 Awaiting requested review from Salim-54

Assignees

@aimedivin aimedivin

Labels

Need Reviews Steppers Team Steppers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Attendance data should be calculated on the server not client

7 participants

@aimedivin @Salim-54 @kanu-cast @elijahladdie @igorihimbazwe @Calebgisa72