Skip to content

TTL-Page improvement #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2024
Merged

TTL-Page improvement #601

merged 4 commits into from
Nov 1, 2024

Conversation

@igorihimbazwe
Copy link
Member

@igorihimbazwe igorihimbazwe commented Oct 24, 2024 •
edited
Loading

PR Description

This pr allows admin to drop and undrop ttl from organisation

Description of tasks that were expected to be completed

-Enforces to insert reason when removing a TTL
-After removing successfully, ensures the button in the modal stops showing loading
-Droping ttl does not drops the user permanently in the app.
-TTL can be undropped

How has this been tested?

  • Clone this repository and navigate to the project directory
  • Ensure You have backend service running and set your .env file using .env.example.
  git clone https://github.com/atlp-rwanda/atlp-pulse-fn.git
  cd atlp-pulse-fn
  git checkout ft-ttl-page
  npm i
  npm run dev

and

  • Clone this repository and navigate to the project directory
  • Ensure You have backend service running and set your .env file using .env.example.
  git clone https://github.com/atlp-rwanda/atlp-pulse-bn.git
  cd atlp-pulse-fn
  git checkout ft-ttl-page
  npm i
  npm run dev

-Login as Admin and try all features

Number of Commits

2 commits

Screenshots (If appropriate)

Screenshot 2024-10-24 at 3 54 03 PM Screenshot 2024-10-24 at 3 54 20 PM Screenshot 2024-10-24 at 3 54 43 PM vin

@vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 10:43am

@igorihimbazwe igorihimbazwe self-assigned this Oct 24, 2024
@igorihimbazwe igorihimbazwe linked an issue Oct 24, 2024 that may be closed by this pull request
Improvement on TTLs page #398
Closed
@igorihimbazwe igorihimbazwe changed the title FtTTL-Page TTL-Page improvement Oct 24, 2024
@Salim-54
Copy link

Salim-54 commented Nov 1, 2024

Please integrate the backend into your Preview.

@Salim-54 Salim-54 merged commit 4c9fc7c into develop Nov 1, 2024
6 checks passed
Bananayosostene pushed a commit that referenced this pull request Nov 21, 2024
@GSinseswa721 @Bananayosostene
sPPS C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop
5b2944b 
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
edit 7d95521 sort invitations by descending or ascending (#590)

s fix-docs (#587)
s b1a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)S C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
s 7d95521 sort invitations by descending or ascending (#590)
s 711747f fix-docs (#587)
s b2a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)ort invitations by descending or ascending (#590)

Co-authored-by: niyobertin <[email protected]>

fix-docs (#587)

fix Internanationalization testimonial section (#592)

changing undrop icon (#583)

fx<search> improving search invitation to listern to typing event (#591)

fix(#404):login activies display in a table (#576)

fix(#403):adding a not found page (#593)

fix(#599): Improve invitation table pagination (#553)

fix(#595):Improve the dark mode skeleton to match dark design (#598)

fix(#404): add skeleton loader on login activities table (#600)

Remove ratings legacy feature #225 (#594)

fix(#391):Enable Consistent Edit For All Cohorts (#607)

-As an admin, I have ability to edit all cohorts that I am permitted to manage

fix(#605):table responsiveness (#611)

Co-authored-by: niyobertin <[email protected]>

(#606) Harmonize action button theme across tables in TTL's portal (#613)

fix(#394): Resolve Trainee Detail View Errors (#614)

average ratings (#617)

TTL-Page improvement (#601)

* droping and undropping ttl

* ft-droping-and-undropping-ttl

* ft-droping-and-undropping-ttl

* ft-ttl-page-improvement

* fix: move client-side attendance logic to server

* feat(trainee-attendance): implements a trainee-side attendance

fix: move client-side attendance logic to server (#596)

Enable admin to view all programs with user breakdown per program-#422 (#618)

(fix): add coordinator dashboard page (#608)

main admin dashboard

new piechart and stats updated

new piechart and stats updated

ft-admin-dashboard-can-vieww-table-teams

new piechart and stats updated
Bananayosostene pushed a commit that referenced this pull request Nov 22, 2024
@GSinseswa721 @Bananayosostene
admin dashoard functinality
f3d9c53 
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
edit 7d95521 sort invitations by descending or ascending (#590)

s fix-docs (#587)
s b1a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)S C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
s 7d95521 sort invitations by descending or ascending (#590)
s 711747f fix-docs (#587)
s b2a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)ort invitations by descending or ascending (#590)

Co-authored-by: niyobertin <[email protected]>

fix-docs (#587)

fix Internanationalization testimonial section (#592)

changing undrop icon (#583)

fx<search> improving search invitation to listern to typing event (#591)

fix(#404):login activies display in a table (#576)

fix(#403):adding a not found page (#593)

fix(#599): Improve invitation table pagination (#553)

fix(#595):Improve the dark mode skeleton to match dark design (#598)

fix(#404): add skeleton loader on login activities table (#600)

Remove ratings legacy feature #225 (#594)

fix(#391):Enable Consistent Edit For All Cohorts (#607)

-As an admin, I have ability to edit all cohorts that I am permitted to manage

fix(#605):table responsiveness (#611)

Co-authored-by: niyobertin <[email protected]>

(#606) Harmonize action button theme across tables in TTL's portal (#613)

fix(#394): Resolve Trainee Detail View Errors (#614)

average ratings (#617)

TTL-Page improvement (#601)

* droping and undropping ttl

* ft-droping-and-undropping-ttl

* ft-droping-and-undropping-ttl

* ft-ttl-page-improvement

* fix: move client-side attendance logic to server

* feat(trainee-attendance): implements a trainee-side attendance

fix: move client-side attendance logic to server (#596)

Enable admin to view all programs with user breakdown per program-#422 (#618)

(fix): add coordinator dashboard page (#608)

main admin dashboard

new piechart and stats updated

new piechart and stats updated

ft-admin-dashboard-can-vieww-table-teams

new piechart and stats updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elijahladdie elijahladdie elijahladdie approved these changes

@Ke-bean Ke-bean Ke-bean approved these changes

@aimedivin aimedivin aimedivin approved these changes

@Calebgisa72 Calebgisa72 Calebgisa72 approved these changes

@kanu-cast kanu-cast Awaiting requested review from kanu-cast

@Salim-54 Salim-54 Awaiting requested review from Salim-54

@rwemakevin rwemakevin Awaiting requested review from rwemakevin

@hatfelicien hatfelicien Awaiting requested review from hatfelicien

Assignees

@igorihimbazwe igorihimbazwe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improvement on TTLs page

7 participants

@igorihimbazwe @Salim-54 @elijahladdie @Ke-bean @aimedivin @Calebgisa72