Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#449 Testimonials redesign #609

Merged
merged 1 commit into from
Nov 25, 2024
Merged

#449 Testimonials redesign #609

merged 1 commit into from
Nov 25, 2024

Conversation

Ke-bean
Copy link
Contributor

@Ke-bean Ke-bean commented Oct 28, 2024 •
edited
Loading

PR Description

This PR is for redesigning the Testimonials page

Screen Shot 2024-11-22 at 08 29 47

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 6:18am

@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from 6e0d90c to d00b680 Compare October 29, 2024 08:31
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from d00b680 to 744833e Compare October 29, 2024 08:36
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from 744833e to 199bb6a Compare October 29, 2024 08:42
@Ke-bean Ke-bean self-assigned this Oct 29, 2024
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from 199bb6a to 752e7ab Compare October 29, 2024 08:45
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from 752e7ab to c387674 Compare October 29, 2024 08:52
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from c387674 to b280c66 Compare October 29, 2024 09:12
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from b280c66 to 44d4d9f Compare October 29, 2024 09:17
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from 44d4d9f to de740b1 Compare October 29, 2024 09:20
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from de740b1 to eaf5180 Compare October 29, 2024 09:24
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from eaf5180 to 1f1c7ad Compare October 29, 2024 09:29
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from 1f1c7ad to 9c7a0f8 Compare October 29, 2024 09:33
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from 9c7a0f8 to a9afcdb Compare October 29, 2024 09:39
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from a9afcdb to aa09c80 Compare October 29, 2024 09:49
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from 69c3397 to 0bfcf03 Compare October 29, 2024 10:45
aimedivin
aimedivin requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@aimedivin aimedivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ke-bean, Remove that horizontal scroll bar and make sure translation for the testimonial section work as I was working before (it was fixed by @rwemakevin),
image

.github/workflows/tests runner.yml Outdated Show resolved Hide resolved
@Ke-bean
Copy link
Contributor Author

Ke-bean commented Oct 30, 2024 •
edited
Loading

@Ke-bean, Remove that horizontal scroll bar and make sure translation for the testimonial section work as I was working before (it was fixed by @rwemakevin), image

@Ke-bean , why is this run removed

Could you clarify which work you said you did before or @rwemakevin's work so that I can reference on what to change? @aimedivin

@aimedivin aimedivin linked an issue Oct 31, 2024 that may be closed by this pull request
Testimonials #449
Closed
@Ke-bean Ke-bean requested a review from aimedivin November 7, 2024 13:36
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from 0bfcf03 to e2d0ec0 Compare November 7, 2024 14:51
@Ke-bean Ke-bean force-pushed the 449_Testimonials_redesign branch from e2d0ec0 to 60c4310 Compare November 22, 2024 06:17
@Salim-54 Salim-54 merged commit ba99305 into develop Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calebgisa72 Calebgisa72 Calebgisa72 approved these changes

@aimedivin aimedivin aimedivin approved these changes

@elijahladdie elijahladdie elijahladdie approved these changes

@Salim-54 Salim-54 Awaiting requested review from Salim-54

@hatfelicien hatfelicien Awaiting requested review from hatfelicien

@amiparadis250 amiparadis250 Awaiting requested review from amiparadis250

Assignees

@Ke-bean Ke-bean

Labels
Need Reviews Steppers Team Steppers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testimonials
5 participants
@Ke-bean @elijahladdie @aimedivin @Calebgisa72 @Salim-54