Skip to content

#606 Harmonize action button theme across tables in TTL's portal #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

#606 Harmonize action button theme across tables in TTL's portal #613

merged 1 commit into from
Oct 31, 2024

Conversation

@UwicyezaG
Copy link
Contributor

@UwicyezaG UwicyezaG commented Oct 29, 2024 •
edited
Loading

PR Description

This PR implements a design update to harmonize the action button theme across tables in TTL's portal

Description of tasks that were expected to be completed

  • Identify and locate the "View More" button under the "Action" column in relevant tables.
  • Replace the "View More" button with the icon, ensuring it adheres to the portal's theme.
  • Style the icon in purple to maintain visual consistency across the portal.
  • Test the updated icon for visual appeal and accessibility.

How has this been tested?

Clone this repository, checkout the this branch, then install all dependencies
login in the app with the following credentials and test the above mentioned features on the invitations page
Link: https://metron-devpulse-git-harmonize-actionbtn-theme-metron.vercel.app/
Organization: Andela
email: [email protected]
password: Test@12345

Number of Commits

1 Commit

Screenshots (If appropriate)

image

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 4:09pm

@niyobertin niyobertin added the Fighters Team Fighters label Oct 29, 2024
@UwicyezaG UwicyezaG force-pushed the harmonize-actionbtn-theme branch from e8d86f1 to 0de793a Compare October 29, 2024 21:56
@niyobertin niyobertin changed the title (#606) Harmonize action button theme across tables in TTL's portal #606 Harmonize action button theme across tables in TTL's portal Oct 30, 2024
@niyobertin niyobertin force-pushed the harmonize-actionbtn-theme branch from 0de793a to b82dc65 Compare October 30, 2024 14:24
@UwicyezaG UwicyezaG force-pushed the harmonize-actionbtn-theme branch from b82dc65 to e5a87e1 Compare October 30, 2024 16:00
@UwicyezaG UwicyezaG force-pushed the harmonize-actionbtn-theme branch from e5a87e1 to af4c414 Compare October 30, 2024 16:02
@UwicyezaG UwicyezaG force-pushed the harmonize-actionbtn-theme branch from af4c414 to 61fe598 Compare October 30, 2024 16:08
@ncutixavier ncutixavier merged commit acbeb7e into develop Oct 31, 2024
6 checks passed
@ncutixavier ncutixavier deleted the harmonize-actionbtn-theme branch October 31, 2024 14:29
Bananayosostene pushed a commit that referenced this pull request Nov 21, 2024
@GSinseswa721 @Bananayosostene
sPPS C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop
5b2944b 
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
edit 7d95521 sort invitations by descending or ascending (#590)

s fix-docs (#587)
s b1a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)S C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
s 7d95521 sort invitations by descending or ascending (#590)
s 711747f fix-docs (#587)
s b2a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)ort invitations by descending or ascending (#590)

Co-authored-by: niyobertin <[email protected]>

fix-docs (#587)

fix Internanationalization testimonial section (#592)

changing undrop icon (#583)

fx<search> improving search invitation to listern to typing event (#591)

fix(#404):login activies display in a table (#576)

fix(#403):adding a not found page (#593)

fix(#599): Improve invitation table pagination (#553)

fix(#595):Improve the dark mode skeleton to match dark design (#598)

fix(#404): add skeleton loader on login activities table (#600)

Remove ratings legacy feature #225 (#594)

fix(#391):Enable Consistent Edit For All Cohorts (#607)

-As an admin, I have ability to edit all cohorts that I am permitted to manage

fix(#605):table responsiveness (#611)

Co-authored-by: niyobertin <[email protected]>

(#606) Harmonize action button theme across tables in TTL's portal (#613)

fix(#394): Resolve Trainee Detail View Errors (#614)

average ratings (#617)

TTL-Page improvement (#601)

* droping and undropping ttl

* ft-droping-and-undropping-ttl

* ft-droping-and-undropping-ttl

* ft-ttl-page-improvement

* fix: move client-side attendance logic to server

* feat(trainee-attendance): implements a trainee-side attendance

fix: move client-side attendance logic to server (#596)

Enable admin to view all programs with user breakdown per program-#422 (#618)

(fix): add coordinator dashboard page (#608)

main admin dashboard

new piechart and stats updated

new piechart and stats updated

ft-admin-dashboard-can-vieww-table-teams

new piechart and stats updated
Bananayosostene pushed a commit that referenced this pull request Nov 22, 2024
@GSinseswa721 @Bananayosostene
admin dashoard functinality
f3d9c53 
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
edit 7d95521 sort invitations by descending or ascending (#590)

s fix-docs (#587)
s b1a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)S C:\Users\B Sostene\Desktop\atlp-pulse-fn> git checkout develop
error: Your local changes to the following files would be overwritten by checkout:
        tests/pages/TraineeAttendance.test.tsx
Please commit your changes or stash them before you switch branches.
s 7d95521 sort invitations by descending or ascending (#590)
s 711747f fix-docs (#587)
s b2a22b6 fix Internanationalization testimonial section (#592)
s df093d2 changing undrop icon (#583)
s b7cb194 fx<search> improving search invitation to listern to typing event (#591)
s 9e05149 fix(#404):login activies display in a table (#576)
s 464657e fix(#403):adding a not found page (#593)
s cc142ef fix(#599): Improve invitation table pagination (#553)
s f08afd4 fix(#595):Improve the dark mode skeleton to match dark design (#598)
s 4321d94 fix(#404): add skeleton loader on login activities table (#600)
s d72b882 Remove ratings legacy feature #225 (#594)
s 6ea7721 fix(#391):Enable Consistent Edit For All Cohorts (#607)
s fe125aa fix(#605):table responsiveness (#611)
s acbeb7e (#606) Harmonize action button theme across tables in TTL's portal (#613)
s 643274e fix(#394): Resolve Trainee Detail View Errors (#614)
s 75d247a average ratings (#617)
s 4c9fc7c TTL-Page improvement (#601)
s 2e47213 #513 refactoring attendance feature on trainee side (#603)
s 58eb885 fix: move client-side attendance logic to server (#596)
s a14728e Enable admin to view all programs with user breakdown per program-#422 (#618)
s 31852e3 (fix): add coordinator dashboard page (#608)ort invitations by descending or ascending (#590)

Co-authored-by: niyobertin <[email protected]>

fix-docs (#587)

fix Internanationalization testimonial section (#592)

changing undrop icon (#583)

fx<search> improving search invitation to listern to typing event (#591)

fix(#404):login activies display in a table (#576)

fix(#403):adding a not found page (#593)

fix(#599): Improve invitation table pagination (#553)

fix(#595):Improve the dark mode skeleton to match dark design (#598)

fix(#404): add skeleton loader on login activities table (#600)

Remove ratings legacy feature #225 (#594)

fix(#391):Enable Consistent Edit For All Cohorts (#607)

-As an admin, I have ability to edit all cohorts that I am permitted to manage

fix(#605):table responsiveness (#611)

Co-authored-by: niyobertin <[email protected]>

(#606) Harmonize action button theme across tables in TTL's portal (#613)

fix(#394): Resolve Trainee Detail View Errors (#614)

average ratings (#617)

TTL-Page improvement (#601)

* droping and undropping ttl

* ft-droping-and-undropping-ttl

* ft-droping-and-undropping-ttl

* ft-ttl-page-improvement

* fix: move client-side attendance logic to server

* feat(trainee-attendance): implements a trainee-side attendance

fix: move client-side attendance logic to server (#596)

Enable admin to view all programs with user breakdown per program-#422 (#618)

(fix): add coordinator dashboard page (#608)

main admin dashboard

new piechart and stats updated

new piechart and stats updated

ft-admin-dashboard-can-vieww-table-teams

new piechart and stats updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncutixavier ncutixavier ncutixavier approved these changes

@GSinseswa721 GSinseswa721 GSinseswa721 approved these changes

@niyobertin niyobertin niyobertin approved these changes

@jniyonkuru jniyonkuru jniyonkuru approved these changes

@Yvan-David Yvan-David Yvan-David approved these changes

@Oliviier-dev Oliviier-dev Oliviier-dev approved these changes

@Ndevu12 Ndevu12 Ndevu12 approved these changes

@mpanoathos mpanoathos Awaiting requested review from mpanoathos

@YvetteNyibuka YvetteNyibuka Awaiting requested review from YvetteNyibuka

Assignees

No one assigned

Labels

Fighters Team Fighters Need Reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@UwicyezaG @ncutixavier @GSinseswa721 @niyobertin @jniyonkuru @Yvan-David @Oliviier-dev @Ndevu12