Skip to content

Conversation

@Yvan-David
Copy link
Contributor

@Yvan-David Yvan-David commented Nov 1, 2024

PR Description

Please include a brief description of the pull request you want to raise.

  • Implement add team such that on ttlEmail it only shows ttls who don't have teams

Description of tasks that were expected to be completed

List all the tasks and sub-tasks that were assigned to you or that you assigned yourself. Make sure you check evey completed task.

How has this been tested?

Please describe the tests that you ran to verify your functionalities. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • click here and login as an admin with email: [email protected] and password: Test@12345
  • visit teams page try to add team and choose ttlEmail
  • check if the suggested email exist in the list of ttls who have an assigned team in TTLS page
  • you will find that his not assigned to any team

Number of Commits

  • 1

The number of commits should not exceed 2 commits. In case they are more than that, please take your time and squash them.

Screenshots (If appropriate)

image
image

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel
Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 1:17pm

@Yvan-David Yvan-David changed the title #392 Implement add team such that on ttlEmail it only shows ttls who don't have teams #392 Implement add team such that only ttls who don't have teams are shown Nov 1, 2024
- Implement add team such that on ttlEmail  it only shows ttls who don't have teams
@ncutixavier ncutixavier merged commit b45bb57 into develop Nov 14, 2024
6 checks passed
@ncutixavier ncutixavier deleted the fix-ttl-oneTeam-392 branch November 14, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants