Skip to content

Ft individual travel history #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 54 commits into
base: develop
Choose a base branch
from
Open

Ft individual travel history #22

wants to merge 54 commits into from

Conversation

@Alice-Gatera
Copy link
Collaborator

@Alice-Gatera Alice-Gatera commented Mar 30, 2021 •
edited
Loading

Description

This set up a project from scratch without using npx create-react-app

Type of change

Please check the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be manually tested or reproduced?

  • Clone this repo
  • Run the command npm i
  • Run the command npm start
  • You need to login as a requester or manager, once you are logged in you go to travel-history then it displays all the trips made, if you want to see the booked accommodation you click on details it will direct you to the page that view the all infos. when you login and no trips made it will give you a message no trips available.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

habaumugisha1 and others added 30 commits January 15, 2021 11:46
@habaumugisha1
manage travel request
c1fa531
@Noel2002
correcting actions travel-request-fetching actions' error handling an…
ff26cba 
…d creating a model for viewing a particular request
@Noel2002
filling the data fetch from database in the dialog box
a713e4b
@Noel2002
removing return column in view modal and positioning date well on the…
6160577 
… request card
@Noel2002
styling side drawer and adding functional drop downs
e386159
@Noel2002
using dotenv base url in travel requests' fetching actions
14551c5
@Noel2002
fixing the postioning of pagination bar
2e449be
@Noel2002
Displaying appropriate error message when an error while approving tr…
c6fa4fd 
…avel requests
@Noel2002
customizing view request dialog
b40d61f
@Noel2002
refactoring codes
6954493
@Noel2002
adding approved badge to approved requests
6e9a2e9
@Noel2002
adding user details and accomodation detals on the cards
b5d6fca
@Noel2002
fixed the update request action to make approve and reject works
da17baf
@Noel2002
categorising requests
b513091
@Noel2002
customizing view modal actions and handling image errors
d5c77a6
@Noel2002
clean up
3478b11
@Noel2002
removing package-lock
0a4d429
@Noel2002
Merge branch 'develop' into ft-manage-request
b6d74eb
@Noel2002
merging cont'
2a1bfc0
@Noel2002
adding responsiveness to viewModal and requestCard
01b0478
@Noel2002
Merge branch 'develop' into ft-manage-request
efd2faf
@Noel2002
updating snapshots
84c0f54
@Noel2002
testing ReportsView, Done, Approved and Rejected&canceled components
6c5843b
@Noel2002
Merge branch 'develop' into ft-manage-request
cd5293a
@Noel2002
removing package-lock
dfc39f5
@Noel2002
recreating package-lock
a48c692
@Noel2002
removing obsolete dateFormat function which was causing errors
588e726
@Blaiseniyo @inezabonte @Alice-Gatera
Ft create roles permissions (#6)
f6a4184 
* created layout for admin

* added data on home screen

* created roles page

* permissions styles

* added count to redux

* made pending true by default

* added data on the home page

* adding roles to database

* created columns for set permissions

* roles and users pages

* users page

* setting permissions

* changed the endpoints

* manager's actions and reducers

* merging files from remote

* refactoring the create roles page

* adding the setpermissions and create roles component

* fixing named import

* fixing named import

* fixing named import

* adding title on list of roles component,succes message on update role

* fixing tests that are failling

* adding some testes and fixing some test

* rebasing

Co-authored-by: inezabonte <[email protected]>
@Alice-Gatera
comment on travel request
1ba651c
@Alice-Gatera
test redux
cd456df
@Alice-Gatera Alice-Gatera requested review from CYIMANA-Faisal, Cyusa144, Noel2002, edgar929 and songa1 and removed request for Noel2002 and edgar929 March 30, 2021 16:45
@Alice-Gatera Alice-Gatera force-pushed the ft-individual-travel-history branch from dda2720 to 3c64a0f Compare March 30, 2021 17:31
@songa1 songa1 self-requested a review March 31, 2021 11:34
songa1
songa1 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@songa1 songa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except that you need to fix the issues with the CI

@Alice-Gatera Alice-Gatera requested a review from edgar929 April 1, 2021 06:06
@Alice-Gatera Alice-Gatera requested a review from Noel2002 April 1, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@songa1 songa1 songa1 approved these changes

@edgar929 edgar929 edgar929 approved these changes

@Cyusa144 Cyusa144 Cyusa144 approved these changes

@CYIMANA-Faisal CYIMANA-Faisal Awaiting requested review from CYIMANA-Faisal

@Noel2002 Noel2002 Awaiting requested review from Noel2002

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Alice-Gatera @songa1 @edgar929 @Cyusa144 @habaumugisha1 @Noel2002 @Blaiseniyo