Fix: Correct Discount Application in Invoice Generation #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angemichel12
requested review from
leandreAlly,
JacquelineTuyisenge,
Hakizimana-Clement,
GarrixA,
cyusasnave and
Tuyisenge2
Tuyisenge2
requested changes
Jul 29, 2024
| (product.price - (product.price * product.discount) / 100) * | ||
| product.quantity | ||
| ).toFixed(2)}{" "} | ||
| Rwf | ||
| </Text> | ||
| </View> |
There was a problem hiding this comment.
yes i can see the discounnt is being applied on each product bought but why on total has no discount included
There was a problem hiding this comment.
I have the same issue too
There was a problem hiding this comment.
i see that issue too
GarrixA
requested changes
Jul 29, 2024
| (product.price - (product.price * product.discount) / 100) * | ||
| product.quantity | ||
| ).toFixed(2)}{" "} | ||
| Rwf | ||
| </Text> | ||
| </View> |
There was a problem hiding this comment.
I have the same issue too
Angemichel12
force-pushed
the
fix-discount-on-invoice
branch
from
6c85f3b to
8834a2b
Compare
Tuyisenge2
approved these changes
Jul 29, 2024
Hakizimana-Clement
approved these changes
Jul 29, 2024
GarrixA
approved these changes
Jul 29, 2024
|
Code Climate has analyzed commit 8834a2b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (60% is the threshold). This pull request will bring the total coverage in the repository to 96.2% (0.0% change). View more on Code Climate. |
leandreAlly
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Displays the price of products after discount on the invoice.
How should this be manually tested?