Skip to content

#172842025: Add Users list in the response of updateRole endpoint #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Kagorora
Copy link
Contributor

What does this PR do?

  • This will Add Users list in the response of updateRole endpoint

Description of Task to be completed?

  • Added Users list the response body of update Role

How should this be manually tested?

  • Clone the project

     https://github.com/Stackup-Rwanda/knights-bn-backend.git
    
  • Move to the branch

     git checkout ch-fix-roleUpdate-response-172842025
    
  • Install all the dependencies and start the server

     npm i && npm run dev-start
    
  • Use the following credentials to log in as an admin

    email: [email protected]
    
    password: Niyonkuru@1
    
  • Use the following endpoint and Body

     URL:
    
     PATCH       
      http://localhost:4000/api/v1/users/[email protected]
    
      Body:
      {  "role": "manager" } 
    

Any background context you want to provide?

  • N/A

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

  • super-admin log in

Screen Shot 2020-05-09 at 12 25 11

  • Update Role(With the Users inside)

Screen Shot 2020-05-14 at 17 08 27

Questions:

  • N/A

@Kagorora Kagorora force-pushed the ch-fix-roleUpdate-response-172842025 branch 4 times, most recently from c84da07 to 95298d0 Compare May 14, 2020 16:06
- added Users list in the response

[Finishes #172842025]
@Kagorora Kagorora force-pushed the ch-fix-roleUpdate-response-172842025 branch from 95298d0 to 2a0d229 Compare May 14, 2020 16:16
@Kagorora Kagorora force-pushed the develop branch 4 times, most recently from 2675b30 to 7d948a7 Compare June 4, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants