Skip to content

Conversation

@sh0hei
Copy link
Contributor

@sh0hei sh0hei commented Feb 13, 2021

No description provided.

@sh0hei sh0hei requested a review from xuwei-k as a code owner February 13, 2021 06:59
README.md Outdated

[![Join the chat at https://gitter.im/atnos-org/eff](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/atnos-org/eff?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
[![Maven Central](https://img.shields.io/maven-central/v/org.atnos/eff_2.13.svg)](https://maven-badges.herokuapp.com/maven-central/org.atnos/eff_2.13)
![CI](https://github.com/atnos-org/eff/workflows/CI/badge.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use badge Markdown generated by GitHub Actions, isn't it? 🤔

  • image
Suggested change
![CI](https://github.com/atnos-org/eff/workflows/CI/badge.svg)
[![CI](https://github.com/atnos-org/eff/actions/workflows/ci.yml/badge.svg)](https://github.com/atnos-org/eff/actions/workflows/ci.yml)

Copy link
Contributor Author

@sh0hei sh0hei Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. you are right 🙏
I'll fixed it 👍

@sh0hei sh0hei force-pushed the add-badge-github-actions-status branch from 96dd416 to fc931f4 Compare November 17, 2021 10:25
@y-yu
Copy link
Contributor

y-yu commented Nov 17, 2021

It seems to be OK. Could you rebase your commits?

@sh0hei sh0hei force-pushed the add-badge-github-actions-status branch from fc931f4 to e07bba6 Compare November 18, 2021 04:13
Copy link
Contributor

@y-yu y-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuwei-k Please check this PR 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants