Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Pull Request list #1523

Merged
merged 146 commits into from
Jun 22, 2018
Merged

Pull Request list #1523

Show file tree
Hide file tree
Changes from 139 commits
Commits
Show all changes
146 commits
Select commit Hold shift + click to select a range
0b46fe1
Accordion component
smashwilson Jun 12, 2018
af6a371
Search Issueishes with an IssueishListContainer
smashwilson Jun 12, 2018
5524183
:fire: .only()
smashwilson Jun 12, 2018
9d4c436
IssueishListController
smashwilson Jun 12, 2018
3ac5236
IssueishListView, first pass
smashwilson Jun 12, 2018
f30be0b
Refactor RemoteSelectorView into its own source file
smashwilson Jun 13, 2018
2d9290e
Search model with factory methods
smashwilson Jun 13, 2018
7bd6203
Use inRemote to implement forCurrentPR
smashwilson Jun 13, 2018
df3158e
IssueishSearchController to house Searches and IssueishListContainers
smashwilson Jun 13, 2018
0f64368
Pass Search through the Issueish components
smashwilson Jun 13, 2018
99481e3
:white_check_mark: RemotePrController tests
smashwilson Jun 13, 2018
1c26fcd
Don't bother to actually execute null searches
smashwilson Jun 13, 2018
4d7a10d
Avoid classname confusion with a BareIssueishListController
smashwilson Jun 13, 2018
639002a
Render a BareIssueishListController directly when loading
smashwilson Jun 13, 2018
7732a3f
Default results to an empty search result
smashwilson Jun 13, 2018
d2a97a1
Update Enzyme expectations
smashwilson Jun 13, 2018
373b0aa
Boolean toggle to show a "create" tile when empty
smashwilson Jun 13, 2018
ae1c067
add some styling to the avatars
Jun 13, 2018
ac27685
Style PR list
simurai Jun 14, 2018
78b2eb4
Add example staus and age
simurai Jun 14, 2018
81e9d95
Load smaller avatar size
simurai Jun 14, 2018
4806ea6
Add overflow scrolling
simurai Jun 14, 2018
8672bcc
Use Node's URL manipulation facilities to append an ?s= query parameter
smashwilson Jun 14, 2018
ff11c09
Prevent the default behavior of clicking on a <details> element
smashwilson Jun 14, 2018
bbb8aba
Don't bother rendering children if an Accordion isn't expanded
smashwilson Jun 14, 2018
431d3b2
Oh right, that isn't always there for Enzyme
smashwilson Jun 14, 2018
2c045fc
Fix it in Enzyme, not in the component
smashwilson Jun 14, 2018
f956556
Pass the props we need for a PR creation tile through IssueishSearch
smashwilson Jun 14, 2018
42b686a
Rename RemotePrController to RemoteController
smashwilson Jun 14, 2018
e567c96
Pass isLoading=false when not loading
smashwilson Jun 14, 2018
6785a37
Accept isLoading from props instead of state
smashwilson Jun 14, 2018
7d3d7e2
onCreatePr is required
smashwilson Jun 14, 2018
46cbe66
Adjust tests for external isLoading prop
smashwilson Jun 14, 2018
a5f70d8
Extract a RemoteContainer from RemoteController
smashwilson Jun 14, 2018
c89c943
I had the wrong schema for defaultBranchRef
smashwilson Jun 14, 2018
bc69723
Explicitly pass a null Repository when we don't care about it
smashwilson Jun 14, 2018
7656d44
Add handleLogout for symmetry
smashwilson Jun 14, 2018
b954c29
Expect the downstream Issueish query
smashwilson Jun 14, 2018
8499d67
Remove RemoteContainer functionality from RemoteController
smashwilson Jun 14, 2018
763b130
Port a CreatePullRequestTile from the existing "publish PR" work
smashwilson Jun 14, 2018
d76743d
Render the RemoteContainer in GithubTabController
smashwilson Jun 14, 2018
f3fa2bf
Move RemotePrController styles to github-IssueishSearch
smashwilson Jun 14, 2018
9a99c1e
Developer art: go :art:
smashwilson Jun 14, 2018
0fa1b39
Some spacing issues
smashwilson Jun 14, 2018
371b16d
Pass attrs to inRemote searches
smashwilson Jun 14, 2018
5f6b828
... Right. Not all currentPR searches are null searches.
smashwilson Jun 14, 2018
048a9bc
Summarize pull request status from Issueish
smashwilson Jun 14, 2018
3293897
A helper that'll let us nix a few eslint ignores
smashwilson Jun 14, 2018
68cc531
Extract StatusDonusChart from PrStatusesController
smashwilson Jun 14, 2018
57dffaf
Query GraphQL for PR status
smashwilson Jun 14, 2018
664b732
Render a check, X, or donut chart
smashwilson Jun 14, 2018
164b612
aheadCount is not always present
smashwilson Jun 14, 2018
39f666d
.status is optional
smashwilson Jun 14, 2018
d5427d3
Give the donut chart a fixed size
smashwilson Jun 14, 2018
7b96adf
Extract donut chart styles
smashwilson Jun 14, 2018
72663d5
Rename github-Accordion-listItem
simurai Jun 15, 2018
f7a7b4c
Add github-IssueishList-item main class
simurai Jun 15, 2018
8a81183
Resize donut ring
simurai Jun 15, 2018
db98550
Update donut chart classNames
smashwilson Jun 15, 2018
7b8b5d6
Match PropTypes to the GraphQL query
smashwilson Jun 15, 2018
411fc99
Render a dash when no status checks are present
smashwilson Jun 15, 2018
5673bd1
Update mock GraphQL responses
smashwilson Jun 15, 2018
a1b1f77
Set an explicit pathLength on the donut chart circle
smashwilson Jun 15, 2018
981faf4
:shirt: Remove unused import
smashwilson Jun 15, 2018
90fdf20
Wire up the createdAt date
smashwilson Jun 15, 2018
f3704c1
Pass a Workspace through GithubTabController
smashwilson Jun 15, 2018
5add636
Support a click handler on an Accordion list item
smashwilson Jun 15, 2018
4d78ee1
Support an onIssueishClick handler
smashwilson Jun 15, 2018
5c3797a
Open an issueish pane on click
smashwilson Jun 15, 2018
6318d93
Pass onOpenIssueish through IssueishListContainer
smashwilson Jun 15, 2018
faa0db9
Render a moreComponent if an Accordion is truncated
smashwilson Jun 15, 2018
0bfd93b
Generate search URLs
smashwilson Jun 15, 2018
c4a0be7
Parse the domain out of a git remote
smashwilson Jun 15, 2018
bcfb4d7
Pass an openSearch handler
smashwilson Jun 15, 2018
edaad70
Render a "More..." link when a list is truncated
smashwilson Jun 15, 2018
3a24cfb
Call onOpenSearch with the appropriate Search
smashwilson Jun 15, 2018
4470838
Make the query limit a prop
smashwilson Jun 15, 2018
616060f
Style the "More..." link
smashwilson Jun 15, 2018
21fe364
Expect the first: query parameter
smashwilson Jun 15, 2018
257306d
:shirt: unused parameter
smashwilson Jun 15, 2018
511b71f
Assert against the arguments to workspace.open
smashwilson Jun 15, 2018
26d3210
Align time ago
simurai Jun 18, 2018
5fe16a5
Add more space to status
simurai Jun 18, 2018
5b27390
Make arrow icon more subtle
simurai Jun 18, 2018
936b43c
Allow IssueishPaneItem to terminate its pending state
smashwilson Jun 18, 2018
f91260d
onDidTerminatePendingState is ignored unless onDidDestroy is there
smashwilson Jun 18, 2018
7be97b8
Extract an ErrorView for persistent (network, GraphQL) failures
smashwilson Jun 18, 2018
53f8dae
Extract a QueryErrorView to handle special case errors
smashwilson Jun 18, 2018
d519c6b
Render a QueryErrorView if a query fails
smashwilson Jun 18, 2018
6decf55
A tile to display if an error happened
smashwilson Jun 18, 2018
6513455
Pull out the response body asynchronously in the network layer
smashwilson Jun 18, 2018
16b64f8
Parse and fail on GraphQL errors
smashwilson Jun 18, 2018
6ffbc50
Pass and render query errors
smashwilson Jun 18, 2018
bbd3f6f
Remove unused empty file
smashwilson Jun 19, 2018
c7c1f5e
OperationStateObserver to observe changes in operation state
smashwilson Jun 19, 2018
f66ed46
PropType for an OperationStateObserver
smashwilson Jun 19, 2018
0f3922e
Derive an observer to trigger events when a remote operation completes
smashwilson Jun 19, 2018
18e2da6
Brrm brrm, prop drilling
smashwilson Jun 19, 2018
f32ef29
Retry issueish searches on remote operation completion
smashwilson Jun 19, 2018
2f9d627
No need to fetch headRepository info
smashwilson Jun 19, 2018
af2942f
Refactor component hierarchy
smashwilson Jun 19, 2018
efafb53
Back out "current PR" Searches
smashwilson Jun 19, 2018
5d3e9fb
Run eslint for fixtures
smashwilson Jun 20, 2018
8ad0306
Pass a remotesByName map down to the IssueishSearchesController
smashwilson Jun 20, 2018
4ae963a
Factory to stamp out GraphQL PR results
smashwilson Jun 20, 2018
8b5b2c9
Implement a CurrentPullRequestContainer
smashwilson Jun 20, 2018
8b4abfa
Make onOpenMore optional
smashwilson Jun 20, 2018
a3f9b6b
Pass emptyComponent through the IssueishListController
smashwilson Jun 20, 2018
c86db41
Only pass the props we actually need to IssueishSearchContainers
smashwilson Jun 20, 2018
e837a01
Default arguments for factories
smashwilson Jun 20, 2018
595a26c
Repository result factory
smashwilson Jun 20, 2018
f6a33b4
Render a CurrentPullRequestContainer beside the active Searches
smashwilson Jun 20, 2018
b111e60
Use the createPullRequestResult factory in IssueishListView tests
smashwilson Jun 20, 2018
b26515e
Generate pull requests with a null status
smashwilson Jun 20, 2018
5920e83
Remove unused atomEnv
smashwilson Jun 20, 2018
9dbc2a8
Query for Repository IDs for the chosen remote and pull requests
smashwilson Jun 20, 2018
3270730
Include headRepositoryID in the Issueish model
smashwilson Jun 20, 2018
aa2937b
Use the pull request factory in IssueishListController tests
smashwilson Jun 20, 2018
0dbacd2
Support a result filter in IssueishListController
smashwilson Jun 20, 2018
65b0007
Filter out pull requests with a different head repository
smashwilson Jun 20, 2018
d53983e
Only show open pull requests as "Current"
smashwilson Jun 20, 2018
1f7dcf8
Rerender the CurrentPullRequestContainer when a push happens
smashwilson Jun 20, 2018
bc89289
Invalidated cached branches when an upstream is set
smashwilson Jun 20, 2018
824a4f7
Default a branch's push upstream to its fetch upstream
smashwilson Jun 20, 2018
d6eb712
Include a __typename in the pull request result fixture
smashwilson Jun 20, 2018
df88b3e
Return a Disposable from the null OperationStateObserver
smashwilson Jun 20, 2018
afd739d
Use result factories in IssueishSearchContainer tests
smashwilson Jun 20, 2018
4bf55ea
Use result factories in RemoteContainer tests
smashwilson Jun 20, 2018
c1caa9f
Bring query expectation name up to date
smashwilson Jun 20, 2018
322faa4
Use result factory in IssueishSearchesController test
smashwilson Jun 20, 2018
35fe747
Set flex-direction: column to center LoadingView
smashwilson Jun 20, 2018
89a896f
Delete unused components
smashwilson Jun 20, 2018
39dab47
Remove unused CSS
smashwilson Jun 20, 2018
dd0a882
Render a "loading" message for each IssueishList
smashwilson Jun 20, 2018
1269ca9
Keep stylesheet name consistent
smashwilson Jun 20, 2018
d3b5cfa
:art: Error styling
smashwilson Jun 20, 2018
66f593d
Response text is extracted beforehand
smashwilson Jun 20, 2018
c523511
Add styling tweaks to messages and controls
simurai Jun 21, 2018
ea66f29
Align status icons
simurai Jun 21, 2018
9eaa3db
Use an IssueishPropType for IssueishListView
smashwilson Jun 21, 2018
aa61a74
Test passing an Error to an IssueishListController
smashwilson Jun 21, 2018
ebee260
(capital H *cough*)
smashwilson Jun 21, 2018
a0c17a7
Test failing to generate search URLs from non-GitHub remotes
smashwilson Jun 21, 2018
e14e981
Merge remote-tracking branch 'origin/master' into aw/accordion-solo
smashwilson Jun 22, 2018
bf45ae2
Split messages into two parts
simurai Jun 22, 2018
66d149c
Fix lint warning
simurai Jun 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
test/fixtures/**/*
/test/fixtures/**/*
!/test/fixtures/factories/**
!/test/fixtures/props/**
Loading