This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Refactor IssueishPaneItemView #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as JS class
Seems un-used
To easier see what belongs together
Since it's its own "component"
simurai
changed the title
|
I'll merge this before @smashwilson is probably gonna edit some of the files. Hopefully nothing broke. 😇 |
smashwilson
added
the
feature request 002
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This refactors
IssueishPaneItemView. a.k.a. "PR details opened in a center pane" view.Benefits
_global.lessClean up_global.less#1251Possible Drawbacks
Might not actually make it more extendable.
Applicable Issues
_global.less#1251