This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Respect GIT_AUTHOR_*/GIT_COMMITTER_* environment variables #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smashwilson
approved these changes
Jun 14, 2017
| env[envVar] = process.env[envVar]; | ||
| } | ||
| }); | ||
|
|
There was a problem hiding this comment.
I feel like I've done this a few times now. It might be worth refactoring into a helper somewhere 🤔
There was a problem hiding this comment.
Oh I think the other times are in #846 which isn't 
yet. And which would be run from a process that can't import helpers easily.
BinaryMuse
pushed a commit
that referenced
this pull request
Aug 1, 2017
Respect GIT_AUTHOR_*/GIT_COMMITTER_* environment variables (cherry picked from commit d7400d0)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIT_AUTHOR_*andGIT_COMMITTER_*environment variables weren't being sent to the Git worker process, so pairing information (such as set by git-pear) didn't work./cc @smashwilson
/cc @jasonrudolph for info