This repository was archived by the owner on Nov 9, 2024. It is now read-only.
delegate: Don't process event for non Element targets. #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Firefox, event targets can be pseudo elements like `text` nodes which don't have `.closest` method. This results in error when delegate tries to handle trigger for a text node target.
|
We're a seeing this error a lot lately. Would be nice to have this merged and new version released. Sad to see this project abandoned |
|
@atomiks any chance you can merge this PR? Even if you don't do a release, it'd be very helpful for us to be able to install a merged upstream commit for get rid of the spammy exception that this fixes. |
amanagr
added a commit
to amanagr/zulip
that referenced
this pull request
Jul 5, 2024
In Firefox, event targets can be pseudo elements like text nodes which don't have .closest method. This results in error when delegate tries to handle trigger for a text node target. Since atomiks/tippyjs#1166 has no response from the developer, we decided to apply this patch ourselves.
amanagr
added a commit
to amanagr/zulip
that referenced
this pull request
Jul 5, 2024
In Firefox, event targets can be pseudo elements like text nodes which don't have .closest method. This results in error when delegate tries to handle trigger for a text node target. Since atomiks/tippyjs#1166 has no response from the developer, we decided to apply this patch ourselves.
timabbott
pushed a commit
to zulip/zulip
that referenced
this pull request
Jul 5, 2024
In Firefox, event targets can be pseudo elements like text nodes which don't have .closest method. This results in error when delegate tries to handle trigger for a text node target. Since atomiks/tippyjs#1166 has no response from the developer, we decided to apply this patch ourselves.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Firefox, event targets can be pseudo elements like
textnodes which don't have.closestmethod. This results in error when delegate tries to handle trigger for a text node target.