feat: Add comprehensive resource protection to database schemas #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add resource limits constants to prevent resource exhaustion attacks - Implement database-level CHECK constraints for large text/JSONB fields - Add varchar length limits for all text fields across all schemas - Replace magic numbers with well-documented constants - Protect against large journal entries, pages, and AI prompts Resource limits implemented: - Text chunks: 1MB max - Block data: 10MB max - JSONB metadata: 1MB max - Page children arrays: 10,000 blocks max - Various varchar fields with appropriate length limits Addresses: #39
Contributor
Author
|
Ran CI locally, everything is passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements comprehensive resource protection across all database schemas to prevent resource exhaustion attacks as outlined in #39.
Changes
Resource Protection Implementation
Resource Limits Applied
Files Modified
Security Impact
Technical Details
Closes #39