Jorge/stripe pr fixes #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorgebaralt
commented
Sep 18, 2025
jorgebaralt
commented
- Clean ups from previous PR (Feat/stripe #66)
- removing hardcoded values
- fixing CI builds
rmolinamir
reviewed
Sep 18, 2025
Contributor
rmolinamir
left a comment
rmolinamir
left a comment
There was a problem hiding this comment.
LGTM almost there - only a few questions.
apps/web/src/app/(app)/(billing)/subscription/_components/subscription-manage-button.tsx
Outdated
Show resolved
Hide resolved
rmolinamir
reviewed
Sep 20, 2025
Contributor
rmolinamir
left a comment
rmolinamir
left a comment
There was a problem hiding this comment.
Listing some changes I will make shortly:
apps/web/src/app/(app)/@header/_components/header-upgrade-pro.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/app/(app)/@header/_components/header-upgrade-pro.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/app/(app)/(billing)/subscription/_components/subscription-manage-button.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/app/(app)/_components/billing/subscription-info.tsx
Outdated
Show resolved
Hide resolved
- Delete old subscription page and move to dashboard structure - Restructure billing components with new subscription management - Move auth pages from (auth) to (dashboard) route group - Add new header subscription button components - Refactor subscription schema from auth to billing package - Add new billing schemas: plan, price, subscription - Update Stripe webhook handlers with new event processing - Remove old Stripe product/price schemas - Update subscription API router and types - Enhance UI components (badge, button) with new variants - Update currency utilities and auth index exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.