Enhancements for the esp32_flash task #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
force-pushed
the
detect_esp32_offset
branch
3 times, most recently
from
5685f2a to
91a5fc9
Compare
UncleGrumpy
force-pushed
the
detect_esp32_offset
branch
from
91a5fc9 to
783d3ad
Compare
UncleGrumpy
force-pushed
the
detect_esp32_offset
branch
2 times, most recently
from
586a1ef to
d334c12
Compare
UncleGrumpy
requested review from
pguyot
and removed request for
bettio and
pguyot
pguyot
reviewed
Dec 8, 2025
src/atomvm_esp32_flash_provider.erl
Outdated
| auto -> | ||
| read_flash_offset(EspTool, Port, Partition, State); | ||
| Val -> | ||
| Offset0 = read_flash_offset(EspTool, Port, Partition, State), |
Collaborator
There was a problem hiding this comment.
Nicer transition behaviour would be to check that offset matches the beginning of any partition (main.avm or named otherwise).
Collaborator
Author
There was a problem hiding this comment.
Good idea! Now if the given offset does not match the expected partition name a warning will be issued, but as long as it is a data partition of a valid subtype (any subtype not specifically reserved for other purposes - i.e. cordump, nvs, nsv_keys, fat, etc) the partition will be used.
src/esp_part_dump.erl
Outdated
| "0xc00", | ||
| TempFile | ||
| ]), | ||
| os:cmd(Cmd), |
Collaborator
There was a problem hiding this comment.
os:cmd doesn't return the status. We may want to use the good old open_port({spawn_executable, Esptool}).
Collaborator
Author
There was a problem hiding this comment.
I updated this file and the esp32_flash provider to use open_port/2, this had the added benefit of faster flash operations and quieter output.
Changes error reporting for the esp32_flash task to include stack trace when rebar3 is executed with DIAGNOSTIC=1 or DEBUG=1. Signed-off-by: Winford <[email protected]>
UncleGrumpy
force-pushed
the
detect_esp32_offset
branch
2 times, most recently
from
3a391b9 to
4d4e57e
Compare
UncleGrumpy
force-pushed
the
detect_esp32_offset
branch
2 times, most recently
from
11dfd1c to
9b7d519
Compare
The `offset` for the beam application partition is now read from the partition table on the attached esp32 device. When a custom partition table is used that does not use `main.avm` for the beam app partition name the `app_partition` parameter should be used to specify the application partition to be flashed. Valid application partition sub-types (the type is `data`) are `phy` or `0xAA`. If the `offset` parameter is specified it will be used to verify that the offset address of the application partition matched the expected value. This may be used to prevent flashing to a standard build of AtomMV for application that require a custom partition table. The `port` that the ESP32 is attached to is now auto discovered by default. When more than one ESP32 device is plugged into USB the port should be specified to control which device is flashed. Error reporting has been improved with descriptive error messages. Dialyzer warnings for the esp32_flash task have been fixed when analyzing atomvm_rebar3_plugin. Signed-off-by: Winford <[email protected]>
UncleGrumpy
force-pushed
the
detect_esp32_offset
branch
from
9b7d519 to
fe79208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include automatic detection of the beam application partition (default
main.avm) to prevent overwriting the wrong flash sectors. This prevents overwriting Elixir library modules for Elixir supported builds, and assures that the application will be written to the same address that AtomVM will load and run. When flashing to a device with a custom partition table theapp_partitionparameter should be supplied if the app partition is not namedmain.avm.Other changes include: