Re-enable native Erlang driver #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadushin
reviewed
Jan 22, 2024
| sda_pin => 21, | ||
| scl_pin => 22 | ||
| }, | ||
| SSD1306Config = #{sda_pin => 21, |
There was a problem hiding this comment.
In general, my preference for formatting is to use 4-space indentation always (not a fan of traditional erlang/emacs formatting).
Some examples:
Map = #{
foo => bar,
bar => tapas
}.
PropList = [
{foo, bar},
{bar, tapas}
].
Fun = fun() ->
// do something
end.
%% file that be consult'd
{foo, [
{bar, [
{tapas, [one, two three] %% if it fits 80 cols
]}
]}.
nested(
function(
call([if, I, am, being, anal])
)
).
fadushin
reviewed
Jan 22, 2024
| -export([init/1, handle_call/3, handle_cast/2, handle_info/2, terminate/2, code_change/3]). | ||
| -export([nif_init/1, nif_clear/1, nif_set_contrast/2, nif_set_text/2, nif_set_bitmap/4, nif_set_qrcode/2]). | ||
| -export([start_link/1, | ||
| start/1, |
fadushin
reviewed
Jan 22, 2024
| -spec start(Config::config()) -> {ok, SSD1306::ssd1306()} | {error, Reason::term()}. | ||
| start(Config) -> | ||
| gen_server:start(?MODULE, maps:merge(?DEFAULT_CONFIG, Config), []). | ||
| -record(state, { |
fadushin
reviewed
Jan 22, 2024
| case initialize_display(I2CBus, Address, Height, Width) of | ||
| ok -> | ||
| {ok, #state{ | ||
| i2c_bus = I2CBus, |
fadushin
reviewed
Jan 22, 2024
| % %% @private | ||
| initialize_display(I2CBus, Address, _Height, _Weight) -> | ||
| Data = << | ||
| ?CONTROL_BYTE_CMD_STREAM:8, |
There was a problem hiding this comment.
indentation (etc). you get the idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the initialization routine that allows the rest of the interface to work. It also wraps the I2C operations using the
i2c_businterface provided by atomvm_lib.This is a convenience wrapping since most devices with an OLED display will usually share the bus with more I2C devices.
The driver does not (yet) provide the rest of the features the NIF version provides, mainly displaying bitmaps and QR codes.
Further PRs will be aimed to address feature parity, cleaning up the configuration API, documentation and initialization options.