Skip to content

fix: guard arin_process_query against empty input #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Koan-Bot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: guard arin_process_query against empty input #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32019f3
fix: add missing empty-input guard to arin_process_query
Koan-Bot May 6, 2026
49d94c8
fix(ci): replace cpm with cpanm for older perl-tester containers
Koan-Bot May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ jobs:
- uses: actions/checkout@v6
- run: perl -V
- name: Install Dependencies
uses: perl-actions/install-with-cpm@v1
with:
cpanfile: "cpanfile"
run: curl -sL https://cpanmin.us | sudo perl - --notest --installdeps .
- run: perl Makefile.PL
- run: make
- run: make test
Expand Down Expand Up @@ -66,7 +64,7 @@ jobs:
- uses: actions/checkout@v6
- run: perl -V
- name: Install Dependencies
run: cpm install -g --show-build-log-on-failure --cpanfile cpanfile
run: cpanm --notest --installdeps .
- run: perl Makefile.PL
- run: make
- run: make test
2 changes: 2 additions & 0 deletions lib/Net/Whois/IANA.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,8 @@ sub arin_process_query (%) {
return ()
if $query{orgid} && $query{orgid} =~ /^\s*(?:RIPE|LACNIC|APNIC|AFRINIC)\s*$/;

return () if !$query{netrange} && !$query{cidr};

$query{permission} = 'allowed';
$query{descr} = $query{orgname};
$query{remarks} = $query{comment};
Expand Down
14 changes: 14 additions & 0 deletions t/07-query-processing.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,20 @@ subtest 'arin_process_query' => sub {
);
is scalar keys %result, 0, 'whitespace-padded orgid still rejected';
};

subtest 'rejects empty input (no netrange or cidr)' => sub {
my %result = Net::Whois::IANA::arin_process_query();
is scalar keys %result, 0, 'returns empty for empty input';
};

subtest 'rejects missing netrange and cidr' => sub {
my %result = Net::Whois::IANA::arin_process_query(
orgname => 'Some Org',
orgid => 'SOMEORG',
nettype => 'Direct Allocation',
);
is scalar keys %result, 0, 'returns empty without netrange or cidr';
};
};

# --- lacnic_process_query ---
Expand Down
Loading