feat: add -timeout parameter to whois_query#62
Draft
Koan-Bot wants to merge 1 commit into
Draft
Conversation
…ride Allow callers to override the connection and read timeout on a per-query basis without modifying the global $WHOIS_TIMEOUT or reconfiguring %IANA. $iana->whois_query(-ip => $ip, -timeout => 10); The override is threaded through source_connect to whois_connect, affecting both the TCP connect timeout and the per-read deadline for that query only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
-timeoutparameter towhois_query()that overrides the per-source timeout for a single query without mutating global state.Why
Users who process mixed workloads (e.g., bulk log parsing with a tight deadline vs. interactive single lookups with generous waits) currently must either modify
$WHOIS_TIMEOUTglobally or build a custom%mywhoishash just to change the timeout. A per-call override is simpler and avoids global side effects.How
whois_queryextracts-timeoutfrom params and passes it tosource_connectsource_connectaccepts an optional third argument; when defined, it replaces the timeout in the server triple before callingwhois_connect_readline_with_timeout)Testing
t/08-whois-query-flow.tverify the timeout threads through correctly🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 109 insertions(+), 5 deletions(-)
Code scan: clean
Tests: failed (5 Failed, 1 test)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline