Remove deprecated items and repo cleanup #875
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
f5a2ef1 to
c6c93c5
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
c6c93c5 to
6d0eb0d
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
6d0eb0d to
c51ae9d
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
c51ae9d to
d22f2af
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
d22f2af to
4a75154
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
4a75154 to
e870e36
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
b44081e to
ca1069c
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
|
I love the overall cleaner feel! Would it make sense to rename |
I don't think it's a big deal to keep it that way, I would definitely rename it if it was user-facing, but the |
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
ca1069c to
678c031
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 12, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 13, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
19ffec5 to
3db2d65
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 13, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
3db2d65 to
1a11179
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 13, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
1a11179 to
2134bd0
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 13, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 13, 2025
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 13, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
2134bd0 to
d768c25
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 13, 2025
jbeaurivage
force-pushed
the
remove-deprecated-items
branch
from
d768c25 to
6bea13e
Compare
jbeaurivage
added a commit
to jbeaurivage/atsamd
that referenced
this pull request
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we have a breaking release lined up, it's a good opportunity to sneak in breaking changes to clean up the repo.
atsamd-halandatsamd-hal-macros).rustfmtclean up, mostly imports in alphabetical ordercargo fmtinstead ofrustfmt. It will automatically respect the individualcrates' Rust editions.
voidandvcelldefmt,rng-coreandembedded-sdmmcdependenciesspi_futureembedded-halimplementations can be used with DMA instead.embedded-hal v0.2. This was long overdue!Closes #784.
I'd like to wait on #814 before merging, because there's no point in touching the
adcmodule - which has some old ehal 0.2 impls - here, since it underwent a major rewrite.Note to maintainers:
Please merge this PR using rebase. Please do not squash the commits!