cargo-embed → probe-rs documentation change - #82
Open
BobAdamsEE wants to merge 7 commits into
Open
Conversation
`cargo-embed` is now a part of `probe-rs`.
Updating per suggestion in contribution guide
BobAdamsEE
marked this pull request as draft
May 5, 2025 15:20
Author
|
This will need further work - probe-rs has issues with the Embed.toml from changes from the initial cargo-embed. Will submit again once I get flashing working. |
michalfita
reviewed
May 5, 2025
michalfita
left a comment
Collaborator
There was a problem hiding this comment.
I'm not author of this demo and I don't use it, hence missed the change that seem to happen in 2023. Thanks for efforts to improve the documentation.
cargo-embed → probe-rs documentation change
tmplt
reviewed
May 5, 2025
Fixed errors that cause cargo embed to not work including show_timestamps as a general default.rtt setting (now per up_channel), halt_afterwards in the default.flashing section, and the channels parameter of default.rtt was split into up_channels and down_channels.
Remove windows style of paths Co-authored-by: Michał Fita <4925040+michalfita@users.noreply.github.com>
Co-authored-by: Michał Fita <4925040+michalfita@users.noreply.github.com>
Per recommendation removed curl | sh notes - users can reference current documentation from probe-rs site directly
Author
|
Resolved review comments and updated Embed.TOML to handle some changes from probe-rs:
|
BobAdamsEE
marked this pull request as ready for review
May 6, 2025 12:31
michalfita
approved these changes
Oct 26, 2025
michalfita
left a comment
Collaborator
There was a problem hiding this comment.
OK, I think it's good enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to install cargo-embed with instructions from the current
boards/atsamv71_xult/README.mdlead to the following:Updated
boards/atsamv71_xult/README.mdwith the relevant instructions forprobe-rsfor Windows / Linux.