Fix incorrect Host Clock Controller's configure() - #89
Open
BradWalker wants to merge 2 commits into
Open
Conversation
Collaborator
|
The PR misses the entry in the |
michalfita
changed the title
configure()
BradWalker
force-pushed
the
fix_for_hal_efc_divisor
branch
from
July 7, 2026 23:31
2abb9bb to
51dc3a1
Compare
Contributor
Author
|
@michalfita , it's fixed now.. |
… clock down to MCK. Minor comment updates.
michalfita
force-pushed
the
fix_for_hal_efc_divisor
branch
from
July 8, 2026 19:06
51dc3a1 to
da4e03b
Compare
michalfita
approved these changes
Jul 8, 2026
michalfita
left a comment
michalfita
left a comment
Collaborator
There was a problem hiding this comment.
On assumption this is tested change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HostClockControllershould use bothpres&divwhen determining the EFC wait state.Like this:
efc.set_wait_states(source.freq().convert() / (pres as u32) / (div as u32))?;Also, minor comment updates.