WIP: switch to dynssz codegen #270
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - just for vibe check ;)
This PR changes the code generator for ssz code to dynamic-ssz.
The dynamic-ssz code generator is reflection based, which comes with major advantages for type resolution as the go linker does all the heavy work.
The disadvantage of this architecture is, that we need a bunch of
codegen.gofiles that reference the types and are used to generate appropriate ssz code on execution.The code generated by dynamic-ssz is currently slightly slower than the code generated by fastssz.
This is mainly coming from call overheads due to the dynamic function approach that the dynssz lib uses. I'm working on flattening the code to resolve this issue.
Biggest benefit of switching to the dynssz codegen: no more pre- and post work to get the damn ssz code generated. The code generator just works out of the box 🎉. It uses types properly and does not require manual edits, which is a huge pain with the existing fastssz code generator.