fix(ci): handle transient API failures in E2E lint/unit gate polling#133
Closed
SebTardif wants to merge 1 commit into
Closed
fix(ci): handle transient API failures in E2E lint/unit gate polling#133SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
The 'Wait for lint and unit gate' step polls the GitHub API to check job status before running E2E tests. If the API returns truncated JSON, jq parse fails and set -Eeuo pipefail kills the step immediately. Add retry-on-failure: validate the API response with jq empty before parsing, and continue the poll loop on transient failures instead of aborting the entire E2E job. Fixes a flaky E2E failure seen on PR #132 (run 26617885011). Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Contributor
Author
|
Fix cherry-picked to main in d70ed2e. Closing as the change is already on the default branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'Wait for lint and unit gate' step polls the GitHub API to check job status before running E2E tests. If the API returns truncated JSON, jq parse fails and
set -Eeuo pipefailkills the step immediately.Fix: Validate the API response with
jq emptybefore parsing, and continue the poll loop on transient failures instead of aborting the entire E2E job.Root cause: PR #132 CI run 26617885011 failed because
gh apireturned an unfinished JSON string, causingjq: parse error: Unfinished string at EOF.