fix: filter FOSSA false positive for pinned k8s.io/client-go#334
Merged
Conversation
FOSSA flags k8s.io/client-go@v0.36.2 as outdated, but this is the latest stable version pinned to match the target K8s API version. Add scripts/fossa-filter.py to strip known false positives from fossa test output while preserving genuine issue detection. The filter supports both JSON and text-based fallback (quality issues sometimes produce empty JSON output). Update fossa.yaml to use the filter script instead of bare fossa test. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The FOSSA License Check on PR #315 (release v0.1.16) fails with:
This is a false positive:
k8s.io/client-go@v0.36.2is the latest stable version, pinned to match the K8s v0.36.x API version that Attune targets.Solution
scripts/fossa-filter.pyto strip known false positives fromfossa testoutput while preserving genuine issue detection.github/workflows/fossa.yamlto runfossa test --format jsonthrough the filter scriptFalse positive patterns handled
k8s.io/golang.org/x/textgolang.org/x/cryptoTesting
Verified locally with simulated FOSSA output: