ci: use PR author instead of actor for Dependabot skip#40
Merged
Conversation
The semantic PR title check used github.actor to skip Dependabot PRs, but github.actor changes to the maintainer when branch updates are triggered via gh pr update-branch. This caused the check to run on Dependabot PRs with the title edit event, failing on uppercase 'Bump'. Switch to github.event.pull_request.user.login which always reflects the original PR author regardless of who triggers synchronize events. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The semantic PR title check skips Dependabot PRs using
github.actor != 'dependabot[bot]'. However,github.actorchanges to the maintainer when branch updates are triggered viagh pr update-branch, causing the check to run on Dependabot PRs and fail on uppercase 'Bump' in the title.Fix
Switch to
github.event.pull_request.user.loginwhich always reflects the original PR author, regardless of who triggers synchronize events.