ci: fix link checker config and broken URL#41
Merged
Conversation
Rename .lychee.toml to lychee.toml to match lychee's default config file name. Since lychee 0.18+, the default is 'lychee.toml' without the dot prefix, so our .lychee.toml was silently ignored and the medium.com exclusion never took effect. Also fix typo in CONTRIBUTING.md: squidfun -> squidfunk (mkdocs-material theme URL was returning 404). Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Link Check fails on PRs #33 and #38 with two broken links:
medium.com 403: Medium blocks automated crawlers. We added
medium.comto the lychee exclude list in PR ci: fix FOSSA and link check failures on PRs #39, but the exclusion never worked because the config file was named.lychee.tomlwhile lychee's default islychee.toml(no dot prefix since 0.18+).squidfun.github.io 404: Typo in CONTRIBUTING.md. The correct domain is
squidfunk.github.io(with ak).Changes
.lychee.tomltolychee.tomlso lychee auto-reads the configsquidfuntosquidfunkin CONTRIBUTING.mdVerification
Ran lychee locally after the fix: 0 errors, 1 excluded (medium.com), 153 OK.