docs: add Chainsaw stable-state assertion convention to AGENTS.md#94
Merged
Conversation
Chainsaw tests that assert transient operator states (InsufficientData) race with the reconcile loop when minimumDataPoints is low. Add testing convention to prefer stable state assertions or script-based polls that accept multiple valid states. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add E2E testing convention: Chainsaw assertions must target stable operator states, not transient ones.
Learned from #87 (PR #92) where the recommend-mode test asserted
Ready=False/InsufficientData(a transient state the operator passes through in seconds withminimumDataPoints=1). The assert raced with the reconcile loop and intermittently timed out.