Skip to content

reworked formatting to formatter from OnSaveAction - #22

Open
knoxfighter wants to merge 1 commit into
atty303:mainfrom
knoxfighter:formatter
Open

reworked formatting to formatter from OnSaveAction#22
knoxfighter wants to merge 1 commit into
atty303:mainfrom
knoxfighter:formatter

Conversation

@knoxfighter

Copy link
Copy Markdown

With the latest release i have the issue that the formatting always fails cause there is no dioxus.dll on my machine. This PR reworks the dependency on that dll to a dependency on the dx command.
Also it is now not a OnSaveAction anymore, but it uses a proper FormattingService that runs on ctrl+alt+L and (if selected) on save.

@atty303

atty303 commented Sep 5, 2025

Copy link
Copy Markdown
Owner

Adding a dependency on the dx command would mean the plugin won’t work just by installing it, and it would introduce new issues such as how to detect the path to dx. The overhead of launching a separate process is also unhappy. I think it’s preferable to keep it working correctly as a DLL.
But, I’m fine with allowing an optional switch to the dx command.

@knoxfighter

knoxfighter commented Sep 5, 2025

Copy link
Copy Markdown
Author

For me it does not work with the DLL cause the dll is nowhere to be found on my system or anywhere, that is the reason i started to change this. Where should that dll come from and be located?

@atty303

atty303 commented Sep 5, 2025

Copy link
Copy Markdown
Owner

The DLL is bundled in the plugin’s JAR, so it should be usable just by installing the plugin from the IDE. However, due to changes in the build configuration in the latest version, the DLL might no longer load on Windows. I’ll check this.

@knoxfighter

knoxfighter commented Sep 5, 2025

Copy link
Copy Markdown
Author

From what i see the dll is not part of the jar for release 1.3.1 and 1.4.0, it is only embedded in the jar in release 1.2.0.
No further releases available to download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants