feat: highlight matches in interactive search #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses `norm` to do fzf-compatible matches when rendering history items in the search panel to highlight the matching ranges of the item this helps see _why_ certain history items have come up note that this will never be 100% perfect as we search on a sqlite query but it should be good enough in most cases
frankh
force-pushed
the
frank/highlight-matches
branch
3 times, most recently
from
440900d to
f608f2c
Compare
frankh
force-pushed
the
frank/highlight-matches
branch
from
f608f2c to
9bdd7e5
Compare
|
@ellie pls |
|
jusssst holding off on this one - i'd like to get 18.5 stable out this week and would like to give this some proper testing for 18.6! sorry for the delay |
|
no worries just wanted to make sure it wasn't forgotten :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #503
highlight the matching parts of commands in the search window fzf style
sometimes it takes a while to be able to see why a command has shown up, this highlighting helps
it uses https://github.com/nomad/norm for fzf style matching which supports all the same prefixes we do except regex matches (which just won't highlight)
NOTE: PR is unfinished (need tests, probably a better way of getting the search input and engine into the renderer), but i wanted to make sure people would want this feature first
also, the highlighting is kind of inversed for the selected row, not sure if there's a better way we can do this though
edit: updated the highlighting to change the color on the selected row instead of unbolding:
Checks