Feature csv import #2669
Feature csv import #2669
Conversation
|
for what it's worth, i've tested this as "works for me": |
| #[derive(Debug)] | ||
| pub struct CsvHistoryImporter; | ||
|
|
||
| fn default_histpath() -> Result<PathBuf> { |
There was a problem hiding this comment.
The default_histpath approach made sense for classic shell history import where there is usually an expected location for data, but I think in this case it isn't needed
Instead, we should make it so that the import csv subcommand takes a mandatory argument of the file to import
There was a problem hiding this comment.
there's not a facility i'm seeing in any of the other importers to specify the location of a file as part of the command line parsing - am i missing it somewhere?
There was a problem hiding this comment.
trying to dig more on this (excuse my rust n00bness) - it looks like it would be either a modification to the main Importer class, which means everything would get an option, but only one of them would support it, or i create a single "one off" function to basically mimic async fn import but takes a path.
are there better options i'm not seeing?
| @@ -26,6 +27,8 @@ pub enum Cmd { | |||
| ZshHistDb, | |||
| /// Import history from the bash history file | |||
| Bash, | |||
| /// Import history from user csv history file | |||
| CsvHistoryImporter, | |||
There was a problem hiding this comment.
| CsvHistoryImporter, | |
| Csv, |
we have atuin import bash, atuin import zsh etc, so atuin import zsh makes more sense here
| @@ -111,6 +114,7 @@ impl Cmd { | |||
| Self::Zsh => import::<Zsh, DB>(db).await, | |||
| Self::ZshHistDb => import::<ZshHistDb, DB>(db).await, | |||
| Self::Bash => import::<Bash, DB>(db).await, | |||
| Self::CsvHistoryImporter => import::<CsvHistoryImporter, DB>(db).await, | |||
There was a problem hiding this comment.
| Self::CsvHistoryImporter => import::<CsvHistoryImporter, DB>(db).await, | |
| Self::Csv => import::<CsvHistoryImporter, DB>(db).await, |
see rename change
this provides a simple csv file import. after reviewing #2556 and #2431, it never seemed like there was an answer to this, so here's my take at a first cut. i will apologize in advance that i'm not super familiar with rust, so feedback is appreciated.
in keeping with the way other parts of the tool operate, we look for a
history.csvfile with the format of:the test provides an example. note that the class/module is called
csv_importer,CsvHistroyImporterbecause I ran into conflicts withcsvand the crate it belongs to, happy to take suggestions.Checks