Skip to content

chore: update flake.nix#3509

Open
erics118 wants to merge 6 commits into
atuinsh:mainfrom
erics118:update-nix
Open

chore: update flake.nix#3509
erics118 wants to merge 6 commits into
atuinsh:mainfrom
erics118:update-nix

Conversation

@erics118

Copy link
Copy Markdown
  • removes default.nix and flake-compat b/c outdated and flakes are pretty much the standard
  • switches from flake-utils to the more modern flake-parts
  • update flake.lock
  • add rust-analyzer
  • removes explicitly including clippy and rustfmt becase they are included with the toolchain
  • adds nixfmt as formatter for the flake itself

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

remove default.nix and flake-compat b/c outdated and flakes are pretty much the standard
switch from flake-utils to the more modern flake-parts
update flake.lock
add rust-analyzer
remove explicitly including clippy and rustfmt becase they are included with the toolchain
@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Fossier: Manual Review Requested

@erics118 is a new contributor. A maintainer should review this PR before merging.

Score Breakdown

Total Score: 64.6/100 | Confidence: 100% | Outcome: REVIEW

Signal Value Score Weight
account_age 2526 1.00 0.09
public_repos 51 1.00 0.05
contribution_history 51 0.26 0.05
follower_ratio 1.09 0.55 0.05
bot_signals False 0.50 0.04
open_prs_elsewhere 7 0.12 0.09
closed_prs_elsewhere 6 0.40 0.10
merged_prs_elsewhere 46 1.00 0.08
prior_interaction 2 0.67 0.08
activity_velocity 0 1.00 0.08
pr_content ... 1.00 0.08
commit_email no_email 0.50 0.04
pr_description ... 0.70 0.05
repo_stars 30058 0.30 0.04
org_membership 0 0.20 0.03
commit_verification ... 1.00 0.04
contributor_stars 10 0.20 0.04

@greptile-apps

greptile-apps Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the Nix flake setup. The main changes are:

  • Removes the legacy default.nix flake-compat entrypoint.
  • Replaces flake-utils with flake-parts.
  • Updates locked Nix inputs.
  • Adds rust-analyzer and a Nix formatter output.

Confidence Score: 4/5

This is close, but the flake hash should be fixed before merging.

  • The changed toolchain hash can make flake evaluation fail.

  • The failure affects normal Nix workflows like build, develop, and flake check.

  • The rest of the flake migration looks contained.

  • flake.nix needs the toolchain hash padding restored.

Important Files Changed

Filename Overview
flake.nix Migrates flake outputs to flake-parts, but the Rust toolchain hash appears to have lost required padding.
flake.lock Refreshes Nix inputs and swaps flake-utils/flake-compat for flake-parts dependencies.
default.nix Removes the non-flake compatibility entrypoint.

Reviews (1): Last reviewed commit: "chore: update flake.nix" | Re-trigger Greptile

Comment thread flake.nix
erics118 and others added 2 commits May 28, 2026 22:38
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@erics118

Copy link
Copy Markdown
Author

nix CI will fail until this PR gets added to unstable (probs a few days): NixOS/nixpkgs#525067

@phanirithvij

phanirithvij commented Jun 1, 2026

Copy link
Copy Markdown

Please don't remove flake-compat, flakes are not infact "pretty much the standard" yet for a reason.

@erics118

erics118 commented Jun 6, 2026

Copy link
Copy Markdown
Author

Added back the default.nix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants