Fix/zsh count multiline#3521
Open
Dilyxs wants to merge 3 commits into
Open
Conversation
Contributor
Fossier: Manual Review Requested
Score BreakdownTotal Score: 65.1/100 | Confidence: 100% | Outcome: REVIEW
|
Contributor
Greptile SummaryThis PR updates zsh history import counting for multiline commands. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix: fixed indentation for zsh" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
when importing zsh_history, if there are multi-line commands, the progress bar displays an incorrect count. This happens because entries() counts physical lines via count_lines and not the commands.
Fix
.entries() now counts joined commands instead of lines.Same complexity, no extra traversal (it already walked the whole file)
Test plan
test_parse_file updated and passing; new test (test_count_lines_multiline does this check more explicitly)
Closes #3008
Checks