x86_64/hpet: guard against subtraction underflow - #364
Merged
Conversation
The subtraction in timer_n_compute_timeout_delta_as_tsc() can underflow because the VMM might not be scheduled for enough time. So we need to guard against subtraction underflow, and detect if the HPET is running behind the deadline. Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
dreamliner787-9
force-pushed
the
hpet_fix_4
branch
from
July 28, 2026 01:22
dd7b42a to
25b2ea8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subtraction in timer_n_compute_timeout_delta_as_tsc() can underflow because the VMM might not be scheduled for enough time. So we need to guard against subtraction underflow, and detect if the HPET is running behind the deadline.