OpenTitan I2C driver, common i2c driver code, i2c bus scan example #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omeh-a
force-pushed
the
cheshire-i2c-v2
branch
2 times, most recently
from
cfdda09 to
0a904ec
Compare
midnightveil
reviewed
Dec 1, 2025
Contributor
midnightveil
left a comment
midnightveil
left a comment
There was a problem hiding this comment.
Design isn't anything new, really, so that's fine.
Some minor comments about the code.
omeh-a
force-pushed
the
cheshire-i2c-v2
branch
4 times, most recently
from
1bb2fd9 to
1c5991a
Compare
midnightveil
approved these changes
Dec 8, 2025
…cture Extracted all common logic from meson i2c driver to a common file and added some new abstractions to make it easier to reuse the existing i2c logic in other drivers. Finalised opentitan i2c Signed-off-by: Lesley Rossouw <[email protected]>
Signed-off-by: Lesley Rossouw <[email protected]>
Signed-off-by: Lesley Rossouw <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
omeh-a
force-pushed
the
cheshire-i2c-v2
branch
from
1c5991a to
68600c2
Compare
Added CI for bus scan example Update style and copyright for cheshire i2c merge Signed-off-by: Lesley Rossouw <[email protected]>
omeh-a
force-pushed
the
cheshire-i2c-v2
branch
from
68600c2 to
e336782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several things to the I2C protocol:
i2c_common.c. All code here can be used unmodified for all i2c drivers.i2c_bus_scanexample which can run on any device - no external tester apparatus needed for CI.... and also adds a driver for https://github.com/au-ts/serengeti 's implementation of the OpenTitan I2C peripherals. This driver technically supports Cheshire too, but Cheshire lacks the peripheral timer required to run any examples so we restrict it to just Serengeti for now.