-
Notifications
You must be signed in to change notification settings - Fork 27
Add network developer docs #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
omeh-a
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all pretty good with some minor grammar things + suggested changes for clarity. I think this could still be condensed a bit further however and I'm not sure that the current structure is ideal for a new reader. E.g. some info like the sdf gen stuff is repeated and I think some headings aren't in the natural order I would want to understand this as a new user. Might be worth reordering some headings to follow more of a top-down instead of bottom-up ordering, since users generally want to start with "How can I use the network for my example" instead of "how does the queueing protocol work"? Alternatively a table of contents with links to headings could be a good solution
I agree with this, especially the ordering, but for the time being I think it is okay and much better than nothing. I don't have that much time to invest in it further for the moment, but I can come back to it next year (also happy for others to do this as well).
Hopefully with the markdown links it should be easy to jump around. There is also an argument that you should force people to read some sections before using the subsystem immediately e.g. like the signalling protocol. In general I like structuring my docs from higher abstraction to lower as well. Table of contents could work too but I'd like it to be standardised for all sDDF docs. Thank you. I have fixed up a lot of the minor things and grammar. Hopefully I have added a bit of clarity. For the moment, if you believe I've fixed everything suggested can we leave the major changes to later and just get this merged as a first start. |
|
#596 can be merged once this is merged (dependent on this PR as it adds/fixes up the docs with it). |
As discussed in person, definitely fine to leave restructuring etc. for later. Just minor thoughts really :) Will merge. |
Signed-off-by: Courtney Darville <[email protected]>
Signed-off-by: Courtney Darville <[email protected]>
Signed-off-by: Courtney Darville <[email protected]>
…r - drop packets instead Signed-off-by: Courtney Darville <[email protected]>
…ers available Signed-off-by: Courtney Darville <[email protected]>
… buffers Signed-off-by: Courtney Darville <[email protected]>
Signed-off-by: Courtney Darville <[email protected]>
Signed-off-by: Courtney Darville <[email protected]>
Mentions #523 in section
### Memory barriers and atomicitysection, this will need to be updated when merged.