Skip to content

Conversation

@Courtney3141
Copy link
Contributor

@Courtney3141 Courtney3141 commented Dec 7, 2025

Mentions #523 in section ### Memory barriers and atomicity section, this will need to be updated when merged.

Copy link
Member

@omeh-a omeh-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all pretty good with some minor grammar things + suggested changes for clarity. I think this could still be condensed a bit further however and I'm not sure that the current structure is ideal for a new reader. E.g. some info like the sdf gen stuff is repeated and I think some headings aren't in the natural order I would want to understand this as a new user. Might be worth reordering some headings to follow more of a top-down instead of bottom-up ordering, since users generally want to start with "How can I use the network for my example" instead of "how does the queueing protocol work"? Alternatively a table of contents with links to headings could be a good solution

@Courtney3141
Copy link
Contributor Author

Courtney3141 commented Dec 11, 2025

All in all pretty good with some minor grammar things + suggested changes for clarity. I think this could still be condensed a bit further however and I'm not sure that the current structure is ideal for a new reader. E.g. some info like the sdf gen stuff is repeated and I think some headings aren't in the natural order I would want to understand this as a new user.

I agree with this, especially the ordering, but for the time being I think it is okay and much better than nothing. I don't have that much time to invest in it further for the moment, but I can come back to it next year (also happy for others to do this as well).

Might be worth reordering some headings to follow more of a top-down instead of bottom-up ordering, since users generally want to start with "How can I use the network for my example" instead of "how does the queueing protocol work"? Alternatively a table of contents with links to headings could be a good solution

Hopefully with the markdown links it should be easy to jump around. There is also an argument that you should force people to read some sections before using the subsystem immediately e.g. like the signalling protocol. In general I like structuring my docs from higher abstraction to lower as well.

Table of contents could work too but I'd like it to be standardised for all sDDF docs.

Thank you. I have fixed up a lot of the minor things and grammar. Hopefully I have added a bit of clarity.

For the moment, if you believe I've fixed everything suggested can we leave the major changes to later and just get this merged as a first start.

@Courtney3141 Courtney3141 requested a review from omeh-a December 11, 2025 08:26
@Courtney3141
Copy link
Contributor Author

#596 can be merged once this is merged (dependent on this PR as it adds/fixes up the docs with it).

@omeh-a
Copy link
Member

omeh-a commented Dec 18, 2025

All in all pretty good with some minor grammar things + suggested changes for clarity. I think this could still be condensed a bit further however and I'm not sure that the current structure is ideal for a new reader. E.g. some info like the sdf gen stuff is repeated and I think some headings aren't in the natural order I would want to understand this as a new user.

I agree with this, especially the ordering, but for the time being I think it is okay and much better than nothing. I don't have that much time to invest in it further for the moment, but I can come back to it next year (also happy for others to do this as well).

Might be worth reordering some headings to follow more of a top-down instead of bottom-up ordering, since users generally want to start with "How can I use the network for my example" instead of "how does the queueing protocol work"? Alternatively a table of contents with links to headings could be a good solution

Hopefully with the markdown links it should be easy to jump around. There is also an argument that you should force people to read some sections before using the subsystem immediately e.g. like the signalling protocol. In general I like structuring my docs from higher abstraction to lower as well.

Table of contents could work too but I'd like it to be standardised for all sDDF docs.

Thank you. I have fixed up a lot of the minor things and grammar. Hopefully I have added a bit of clarity.

For the moment, if you believe I've fixed everything suggested can we leave the major changes to later and just get this merged as a first start.

As discussed in person, definitely fine to leave restructuring etc. for later. Just minor thoughts really :) Will merge.

@omeh-a omeh-a merged commit 6f17d9d into main Dec 18, 2025
14 checks passed
@omeh-a omeh-a deleted the net_dev_docs branch December 18, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants