fix: blk example qemu_virt_riscv64 args for qemu #604
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Willmish
commented
Jan 15, 2026
Willmish
commented
- On some version of qemu, older version of virtIO MMIO are used by default, causing the blk example to crash. qemu_virt_aarch64 already has that fix and both platforms use correct arguments when ran with zig build system.
- See: https://gitlab.com/qemu-project/qemu/-/issues/1342#note_2869925359
* On some version of qemu, older version of virtIO MMIO are used by default, causing the blk example to crash. qemu_virt_aarch64 already has that fix and both platforms use correct arguments when ran with zig build system. * See: https://gitlab.com/qemu-project/qemu/-/issues/1342#note_2869925359 Signed-off-by: Szymon Duchniewicz <[email protected]>
Contributor
Author
|
blk example was failing to run when ran through the qemu command with args from the make build system, when running on Alternatively, both args can be moved to |
Collaborator
|
The examples are probably better for this rather than the board specific options, however it's unlikely anyone would use the boards while also wanting legacy virtIO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.