Improve support for x86 hardware - #23
Conversation
Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
| await self._acquire_lock() | ||
|
|
||
| self.process = await asyncio.create_subprocess_exec( | ||
| # fmt: off |
There was a problem hiding this comment.
Why did you remove the fmt: off and change all the formatting here?
| } | ||
|
|
||
|
|
||
| def board_is_x86(board: str) -> bool: |
There was a problem hiding this comment.
Hrm. Not sure if I like this. I'd rather make MACHINE_QUEUE_BOARDS be called PLATFORMS and contain this information:
"skylake": {
"arch": Arch.x86_64.with_features(vtx),
"mq_board_names": ["skylake", "skylake1", "skylake2"],
},
"qemu_virt_x86_64": {
...
}
Or something like that.
|
|
||
| cmd_args.extend( | ||
| [ | ||
| "-f", |
There was a problem hiding this comment.
This should look like
cmd_args.extend([
"-f", self.image_file.resolve()",
"-s", self.chosen_board
])
But also, you can just do -s before the files and then you can always add it, and then it should really be more like then:
match board.arch:
case arch.x86:
cmd_args.extend(["-f", ..., "-f", ...")
case arch.aarch64 | arch.riscv64:
cmd_args.extend(["-f", ..."])
But also, in general, I don't want to assume that the layout of the directory.
i.e. self.image_file.parent.resolve() assumes that the layout is a specific way. It won't work if you pass --loader-image as a cmd line argument or if you build is slightly different.
There was a problem hiding this comment.
tldr; this needs more thought.
I also don't know how in CI we handle things like "we want to run NVMe on these x86 boards" and also "not-NVMe on these" etc
There was a problem hiding this comment.
Alternatively, we could make machine queue just take a list of -f arguments instead.
2 participants
No description provided.