Fix Main.panel crash on log out
#784
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destroy, so thatMain.panelis not called after that event.enable(),disable()andreset()methods.Main.panelaccessed after being disposed on GNOME Log Out #782.CoverflowAltTabBlur.Here are the logs after this change:
Debug Logs
You can see in the logs "cannot update light text classname, Main.panel is not alive", so it still tries to update the
Main.panelstyle, but the flag protects against it.I also tried to make
disable()run beforeMain.panel::destroy, but I don't think it's possible, at least not on GNOME 49.rc. The order of events on log out seems to beMain.panel::destroy=>global.display::workareas-changed=>Extension.disable.