-
Notifications
You must be signed in to change notification settings - Fork 0
#225: Add share functionality #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
aura-historia | f376ed8 | Dec 28 2025, 05:10 PM |
|
Feel free to say what can be added/removed. I assume that Reddit can probably be removed? |
bruderj15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat. Not quite sure about the styling yet though (the blank white background doesn't really fit the theme imo).
Keep Reddit (it's broken for me though - links dies).
Instead of just sharing product-title and link, consider adding an i18n text ahead. Something along the lines of: "I found this on Aura Historia. It may be interesting for you!"
Yes, it's still in draft form and not finished yet. I just wanted to ask about the link options, what we should include and leave out, and get a first impression of how it looks overall. Thanks for the feedback. |
That's a bug in the library. It generates the URL for me, and the URL has But the topic is quite interesting: Previously, Reddit Share didn't work without But now it doesn't work with /web again, and we get the “Page not found” error, i.e., thje owner says: “I don't have time to check what the correct URL is. I don't want to switch back and forth between releases.” Several devs have been asking for this to be fixed since July, but nothing has happened. It seems like it won't be merged anymore xD (nygardk/react-share#572) Then I'll have to do it manually. EDIT (for me later): Downgrading to version 5.1.1 is not possible, as you would also have to downgrade React. However, a (temporary) solution to the problem may be found here: nygardk/react-share#571 |
Let's not add another glossy layer on top. Just use the background color we use for the whole page and make it fully opaque. |
The page does not have a background color set (see styles.css). The landing page has --linear-gradient-main (the color gradient) and the remaining pages ONLY have a background image (the lines, see __root.tsx) and therefore use the browser's default value for the background color. I'll go with bg-background for now (which corresponds to --color-neutral-50 (light gray). That puts us in line with what Julian says, but it's okay with me for now. (Discussed in Discord, here just for the record.) |
|
I created a patch for react-share because the RedditShareButton was using the wrong URL (/web/submit instead of /submit). The patch is located in the patches folder and is automatically applied when you run |
|
The header has z-50. I set it to z-40 here, removed this one thing, and set all text except Reddit to personalized. @lfranke42 |
|






Bildschirmaufzeichnung.vom.27.12.2025.22.15.49.webm