Skip to content

Conversation

@BauZee
Copy link
Contributor

@BauZee BauZee commented Dec 27, 2025

Bildschirmaufzeichnung.vom.27.12.2025.22.15.49.webm

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 27, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
aura-historia f376ed8 Dec 28 2025, 05:10 PM

@BauZee
Copy link
Contributor Author

BauZee commented Dec 27, 2025

Feel free to say what can be added/removed. I assume that Reddit can probably be removed?

@BauZee BauZee self-assigned this Dec 27, 2025
@BauZee BauZee marked this pull request as draft December 27, 2025 21:18
Copy link
Contributor

@bruderj15 bruderj15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat. Not quite sure about the styling yet though (the blank white background doesn't really fit the theme imo).

Keep Reddit (it's broken for me though - links dies).

Instead of just sharing product-title and link, consider adding an i18n text ahead. Something along the lines of: "I found this on Aura Historia. It may be interesting for you!"

@BauZee
Copy link
Contributor Author

BauZee commented Dec 27, 2025

Looks neat. Not quite sure about the styling yet though (the blank white background doesn't really fit the theme imo).

Keep Reddit (it's broken for me though - links dies).

Instead of just sharing product-title and link, consider adding an i18n text ahead. Something along the lines of: "I found this on Aura Historia. It may be interesting for you!"

Yes, it's still in draft form and not finished yet. I just wanted to ask about the link options, what we should include and leave out, and get a first impression of how it looks overall. Thanks for the feedback.

@BauZee
Copy link
Contributor Author

BauZee commented Dec 27, 2025

Looks neat. Not quite sure about the styling yet though (the blank white background doesn't really fit the theme imo).

Keep Reddit (it's broken for me though - links dies).

Instead of just sharing product-title and link, consider adding an i18n text ahead. Something along the lines of: "I found this on Aura Historia. It may be interesting for you!"

image

That's a bug in the library. It generates the URL for me, and the URL has ... /web/submit?url=.... I removed the /web` from it, and then it worked, as you can see in the picture.

But the topic is quite interesting:

Previously, Reddit Share didn't work without /web. Then /web was added in v5.1.1 because the URL wasn't working at the time, and that fixed the problem. (nygardk/react-share#547)

But now it doesn't work with /web again, and we get the “Page not found” error, i.e.,/web/submitis no longer a valid URL on Reddit. Now there is a PR that wants to remove /web again and confirms that/submit(without /web) is the correct URL. BUT: The PR has been open for 9 months and has not been merged.

thje owner says: “I don't have time to check what the correct URL is. I don't want to switch back and forth between releases.” Several devs have been asking for this to be fixed since July, but nothing has happened. It seems like it won't be merged anymore xD (nygardk/react-share#572)

Then I'll have to do it manually.

EDIT (for me later): Downgrading to version 5.1.1 is not possible, as you would also have to downgrade React. However, a (temporary) solution to the problem may be found here: nygardk/react-share#571

@BauZee
Copy link
Contributor Author

BauZee commented Dec 27, 2025

Looks neat. Not quite sure about the styling yet though (the blank white background doesn't really fit the theme imo).

Keep Reddit (it's broken for me though - links dies).

Instead of just sharing product-title and link, consider adding an i18n text ahead. Something along the lines of: "I found this on Aura Historia. It may be interesting for you!"

image image

Another design option would be to adopt the style of the card. Personally, I prefer that to the white, but two glassy layers on top of each other—I'm not quite sure what to make of that. Perhaps one could also consider another position. What do you think?

@lfranke42
Copy link
Contributor

Another design option would be to adopt the style of the card. Personally, I prefer that to the white, but two glassy layers on top of each other—I'm not quite sure what to make of that. Perhaps one could also consider another position. What do you think?

Let's not add another glossy layer on top. Just use the background color we use for the whole page and make it fully opaque.

@BauZee
Copy link
Contributor Author

BauZee commented Dec 28, 2025

Another design option would be to adopt the style of the card. Personally, I prefer that to the white, but two glassy layers on top of each other—I'm not quite sure what to make of that. Perhaps one could also consider another position. What do you think?

Let's not add another glossy layer on top. Just use the background color we use for the whole page and make it fully opaque.

The page does not have a background color set (see styles.css). The landing page has --linear-gradient-main (the color gradient) and the remaining pages ONLY have a background image (the lines, see __root.tsx) and therefore use the browser's default value for the background color.

I'll go with bg-background for now (which corresponds to --color-neutral-50 (light gray). That puts us in line with what Julian says, but it's okay with me for now. (Discussed in Discord, here just for the record.)

@BauZee
Copy link
Contributor Author

BauZee commented Dec 28, 2025

I created a patch for react-share because the RedditShareButton was using the wrong URL (/web/submit instead of /submit).

The patch is located in the patches folder and is automatically applied when you run pnpm install, meaning that you or other developers don't have to change anything yourself.

@BauZee BauZee changed the title feat#225: add share functionality #225: Add share functionality Dec 28, 2025
@BauZee BauZee marked this pull request as ready for review December 28, 2025 16:27
@BauZee
Copy link
Contributor Author

BauZee commented Dec 28, 2025

The header has z-50. I set it to z-40 here, removed this one thing, and set all text except Reddit to personalized. @lfranke42

@sonarqubecloud
Copy link

@lfranke42 lfranke42 linked an issue Dec 28, 2025 that may be closed by this pull request
@BauZee BauZee requested a review from lfranke42 December 28, 2025 17:11
@BauZee BauZee merged commit bf8185b into develop Dec 28, 2025
8 of 9 checks passed
@BauZee BauZee deleted the feature/#225-Share-Product-Functionality branch December 28, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share item

4 participants