Sub filter and new interfaces.#4
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| public function apply(&$values): bool; | ||
|
|
||
| public function getFailures(): FailureCollectionInterface; | ||
| public function apply(array|object $values): FilterResultInterface; |
There was a problem hiding this comment.
@pmjones @koriym any objections from moving away from this ?
Earlier we were changing values internally, now we are returning FilterResult . Please see below.
If you agree with this, then I will merge auraphp/Aura.Filter#166 and auraphp/Aura.Input#80
There was a problem hiding this comment.
@harikt No objections. Moving from mutating &$values with a boolean return to an immutable FilterResult is the right direction — I'm in favor.
2 participants
No description provided.