-
Notifications
You must be signed in to change notification settings - Fork 257
feat: nvidia_nim encoder #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
=======================================
Coverage 74.25% 74.25%
=======================================
Files 48 48
Lines 4373 4374 +1
=======================================
+ Hits 3247 3248 +1
Misses 1126 1126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incorrect Default Model for Embeddings
The default embedding_model
for NVIDIA_NIM
is incorrectly set to "meta/llama3-70b-instruct"
. This model is a language model, not an embedding model, which causes failures when generating embeddings with default settings. The default should be an actual embedding model, such as "nvidia/nv-embedqa-e5-v5"
, as indicated in documentation and usage examples.
semantic_router/utils/defaults.py#L31-L39
semantic-router/semantic_router/utils/defaults.py
Lines 31 to 39 in a4b7ea7
} | |
NVIDIA_NIM = { | |
"embedding_model": os.getenv( | |
"NVIDIA_NIM_MODEL_NAME", "meta/llama3-70b-instruct" | |
), | |
"language_model": os.getenv( | |
"NVIDIA_NIM_CHAT_MODEL_NAME", "meta/llama3-70b-instruct" | |
), | |
} |
Was this report helpful? Give feedback by reacting with 👍 or 👎
PR Type
Description
Added Jina, NVIDIA NIM, Voyage encoder classes.
Integrated new encoder types in AutoEncoder.
Updated defaults, schema and tests accordingly.
Provided new notebooks for encoder usage.
Changes walkthrough 📝
6 files
Integrate new Jina, Nim, Voyage encoder imports
Add new JinaEncoder implementation class
Add new NimEncoder for Nvidia NIM service
Add new VoyageEncoder class for Voyage models
Extend EncoderType enum with new encoder types
Add default configurations for new encoders
1 files
Refine name splitting for encoder instantiation
1 files
Add test matrix entries for new encoder types
4 files
Document Jina encoder usage with notebook
Update mistral version from 1.1.6 to 0.1.8
Include notebook for Nvidia NIM encoder demonstration
Add notebook documenting Voyage encoder usage