Feat: merge rlease v2.2.1 - Prague refactoring#104
Conversation
* Gasometr: refactoring and improvements * Bump version to: v2.2.1 * Extend doc comment for calculate_intrinsic_gas_and_gas_floor * feat: introduce gas_floor_base_cost for EIP-7623 compliance (#101) * feat: introduce gas_floor_base_cost for EIP-7623 compliance * fix: replace simple arithmetic operations with saturating_* analogs for gas calculations * chore: remove gas_floor_base_cost constant --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
WalkthroughRefactors the gasometer to extract intrinsic and floor gas computation into three new functions: Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@evm/src/gasometer/mod.rs`:
- Around line 505-511: Fix the typo in the comment ("cas_cost" → "gas_cost") and
make the gas check use the same accessor consistently: replace the earlier use
of self.gas() with self.gas_limit() so the EIP-7623 floor check uses
self.gas_limit() for both comparisons; update the comment to read "gas_cost" and
ensure the conditional still checks self.config.has_floor_gas &&
self.gas_limit() < floor_gas and sets self.inner = Err(ExitError::OutOfGas) /
returns Err(ExitError::OutOfGas) as before.
Gasometr: refactoring and improvements
Bump version to: v2.2.1
Extend doc comment for calculate_intrinsic_gas_and_gas_floor
feat: introduce gas_floor_base_cost for EIP-7623 compliance (feat: introduce gas_floor_base_cost for EIP-7623 compliance #101)
feat: introduce gas_floor_base_cost for EIP-7623 compliance
fix: replace simple arithmetic operations with saturating_* analogs for gas calculations
chore: remove gas_floor_base_cost constant
Summary by CodeRabbit
Refactor
Behavior
Documentation