Skip to content

Add randomize colors shortcut - #48

Merged
aurorascharff merged 9 commits into
aurorascharff:mainfrom
jamesmontemagno:copilot/add-random-colors-menu-dropdown
May 30, 2026
Merged

Add randomize colors shortcut#48
aurorascharff merged 9 commits into
aurorascharff:mainfrom
jamesmontemagno:copilot/add-random-colors-menu-dropdown

Conversation

@jamesmontemagno

@jamesmontemagno jamesmontemagno commented May 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keeps Randomize Colors as an assignable keyboard shortcut
  • reuses the Settings randomizer through shared style-randomization logic
  • removes the menu-bar randomize action so the status menu stays focused

Testing

  • Built locally with ./build-app.sh

Copilot AI review requested due to automatic review settings May 30, 2026 04:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a "Randomize Colors" action accessible from the menu-bar color submenu and as an assignable global shortcut, while consolidating the randomization logic into a single ClickSettings.applyRandomizedStyle() method.

Changes:

  • Introduces a new randomizeColors shortcut action with persistence and default-binding plumbing.
  • Moves the randomization logic from the settings view model into ClickSettings so it can be reused from the menu and the hotkey handler.
  • Adds a "Randomize Colors" entry to the menu-bar color submenu and documents the new feature in the README.
Show a summary per file
File Description
Sources/ClickLight/HotKeyBinding.swift Adds the randomizeColors case, title, sort order, and default binding (nil).
Sources/ClickLight/SettingsStore.swift Adds storage, defaults, and persistence keys for the new hotkey; introduces applyRandomizedStyle().
Sources/ClickLight/SettingsWindowController.swift Replaces inline randomization with a call to applyRandomizedStyle().
Sources/ClickLight/StatusController.swift Adds the menu item and action handler for randomizing colors.
Sources/ClickLight/AppDelegate.swift Wires the new shortcut action to apply randomized style.
README.md Documents the new menu entry and shortcut.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 6/6 changed files
  • Comments generated: 0

@aurorascharff

Copy link
Copy Markdown
Owner

Thanks for the PR! I'm wondering if this is too much for the basic menu, though. I would prefer to keep it esserntial, and "fun" features are better suited in the UI (thanks for making that!). The menu is already big 😅

CleanShot 2026-05-30 at 12 29 29@2x

@aurorascharff

Copy link
Copy Markdown
Owner

The crowded menu wsa adressed here: #50

But I still dont think we need a keybind for the randomize 🤔

@jamesmontemagno

jamesmontemagno commented May 30, 2026

Copy link
Copy Markdown
Contributor Author

I do agree, there is a lot happening in the menu! I do like the keyboard shortcut. Maybe I can just keep that in there?

@jamesmontemagno

Copy link
Copy Markdown
Contributor Author

I'll let you know when ready

@jamesmontemagno

Copy link
Copy Markdown
Contributor Author

Alright I think it is good. Coding with Copilot from the GitHub app while I am on a plane to SF for Build! What a time to be alive.

I don't have my Mac with me so can't test it, but looks correct via my review

@aurorascharff aurorascharff changed the title Add menu randomize colors action and shortcut plumbing Add randomize colors shortcut May 30, 2026
@aurorascharff
aurorascharff merged commit 71fa940 into aurorascharff:main May 30, 2026
2 checks passed
@jamesmontemagno

Copy link
Copy Markdown
Contributor Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants