fix: strip :native_compiled before the evaluator fallback - #165
Merged
ausimian merged 1 commit intoJun 6, 2026
Conversation
`drop_native_opts/1` removes the Emily-only native knobs before the graceful `native_fallback: :eval` path delegates to `Nx.Defn.Evaluator`, but it missed `:native_compiled` (added in CM14). Drop it too so the function matches its own comment and no Emily-only option leaks into the evaluator's option list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to CM14 (#163 review).
drop_native_opts/1strips the Emily-only native knobs before the gracefulnative_fallback: :evalpath delegates toNx.Defn.Evaluator, but it missed:native_compiled(added in CM14). This drops it too, so the helper matches its own comment and no Emily-only option leaks into the evaluator's option list.Harmless today (the evaluator ignores unknown opts) but latent if a future Nx validates its option list. One-line change;
mix precommitgreen.