fix: silence third-party header warnings via -isystem - #2
Merged
Conversation
MLX's bf16.h triggers -Wdeprecated-copy on its own implicit copy assignment operator. The warning isn't actionable from our side — it's an upstream issue — but it clutters the build log and, with -Werror, would break CI. Switch `-I` to `-isystem` for both MLX and fine includes so the compiler treats them as system headers and suppresses diagnostics inside them. Our own code keeps full warning coverage under $(ERTS_INCLUDE_DIR)/-I paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-isysteminstead of-I; compiler treats them as system headers and suppresses diagnostics inside them.-Wdeprecated-copyfrom MLX'sbf16.hthat showed up as a GitHub Actions annotation on the CI PR build (benign, but alarming in the UI and would trip-Werror).-Wall -Wextra -Werrorviamix precommit.Test plan
rm -rf+mix compile --force --warnings-as-errors) — clean, zero warnings.